Skip to content

krun: passt - don't map the gateway address #2099

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
dustymabe wants to merge 1 commit into
base: main
Choose a base branch
from
+7 −1
Open

krun: passt - don't map the gateway address #2099

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 7 additions & 1 deletion src/libcrun/handlers/krun.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -567,7 +567,7 @@ libkrun_start_passt (void *cookie, libcrun_container_t *container)
{
struct krun_config *kconf = (struct krun_config *) cookie;
pid_t pid;
char *passt_argv[9];
char *passt_argv[10];
char fd_as_str[16];
int use_passt;
int argv_idx;
Expand Down Expand Up @@ -598,6 +598,12 @@ libkrun_start_passt (void *cookie, libcrun_container_t *container)
passt_argv[argv_idx++] = (char *) "--no-dhcp-dns";
}

/* Set --no-map-gw. If the gateway for the network is also the DNS server
* we won't be able to query the DNS server without --no-map-gw.
* See discussion in https://github.com/containers/crun/pull/2099
*/
passt_argv[argv_idx++] = (char *) "--no-map-gw";

passt_argv[argv_idx++] = (char *) "--fd";
passt_argv[argv_idx++] = fd_as_str;
passt_argv[argv_idx] = NULL;
Expand Down
Loading