Skip to content

feat: add make target to install claude-agent-acp #949

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
Deepak8858 wants to merge 1 commit into
base: main
Choose a base branch
from
+13 −1
Open

feat: add make target to install claude-agent-acp #949

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
14 changes: 13 additions & 1 deletion build/evals.mk
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,21 +7,33 @@ MCP_CONFIG_DIR ?= dev/config/mcp-configs

MCPCHECKER = $(shell pwd)/_output/tools/bin/mcpchecker
MCPCHECKER_VERSION ?= latest
CLAUDE_AGENT_ACP = $(shell pwd)/_output/tools/bin/claude-agent-acp
CLAUDE_AGENT_ACP_VERSION ?= latest

EVAL_CONFIG ?= evals/openai-agent/eval.yaml
EVAL_LABEL_SELECTOR ?= suite=kubernetes
EVAL_TASK_FILTER ?=
EVAL_VERBOSE ?= false

# Download and install mcpchecker if not already installed
.PHONY: mcpchecker
mcpchecker:
mcpchecker: claude-agent-acp
@[ -f $(MCPCHECKER) ] || { \
set -e ;\
echo "Installing mcpchecker $(MCPCHECKER_VERSION) to $(MCPCHECKER)..." ;\
mkdir -p $(shell dirname $(MCPCHECKER)) ;\
GOBIN=$(shell dirname $(MCPCHECKER)) go install github.com/mcpchecker/mcpchecker/cmd/mcpchecker@$(MCPCHECKER_VERSION) ;\
}

.PHONY: claude-agent-acp
claude-agent-acp:
@[ -f $(CLAUDE_AGENT_ACP) ] || { \
set -e ;\
echo "Installing claude-agent-acp $(CLAUDE_AGENT_ACP_VERSION) to $(CLAUDE_AGENT_ACP)..." ;\
mkdir -p $(shell dirname $(CLAUDE_AGENT_ACP)) ;\
GOBIN=$(shell dirname $(CLAUDE_AGENT_ACP)) go install github.com/mcpchecker/claude-agent-acp/cmd/claude-agent-acp@$(CLAUDE_AGENT_ACP_VERSION) ;\
Copy link
Copy Markdown
Collaborator

@Cali0707 Cali0707 Mar 24, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is not the correct claude-agent-acp (and also does not exist).

The real one is here: https://github.com/zed-industries/claude-agent-acp

In the future, if you are using an LLM to help contribute I would recommend double checking the output

}

##@ Evals

.PHONY: run-evals
Expand Down