Skip to content

fix(evals): enable core toolset for tekton eval suite#959

Merged
Cali0707 merged 1 commit intocontainers:mainfrom
ksimon1:enable-core-toolset-tekton
Mar 25, 2026
Merged

fix(evals): enable core toolset for tekton eval suite#959
Cali0707 merged 1 commit intocontainers:mainfrom
ksimon1:enable-core-toolset-tekton

Conversation

@ksimon1
Copy link
Copy Markdown
Contributor

@ksimon1 ksimon1 commented Mar 24, 2026

fix(evals): enable core toolset for tekton eval suite

This should fix some of the eval tests in #892

@@ -139,7 +139,7 @@ jobs:
Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@ksimon1 I think we need the same here (maybe for other toolsets too)

Would you mind setting core enabled on all the different paths here?

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

cc @aljesusg @lyarwood @ksimon1

Please double check if for your prescribed usage of the MCP server you're encouraging users to enable both core and kiali/kubevirt.
My understanding is the same as Calum's, but it be good to get your approval too.

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@lyarwood already created similar PR #841, so for Kubevirt and Tekton it should be ok.

@ksimon1 ksimon1 force-pushed the enable-core-toolset-tekton branch 3 times, most recently from d3d6f0e to cd49da3 Compare March 25, 2026 12:50
…uites

- kubevirt suite: enable core,config,kubevirt toolsets
- kiali suite: enable core,config,kiali toolsets
- tekton suite: enable core,tekton toolsets (config not needed)

Co-Authored-By: Claude Sonnet 4.5 <noreply@anthropic.com>
Signed-off-by: Karel Simon <ksimon@redhat.com>
@ksimon1 ksimon1 force-pushed the enable-core-toolset-tekton branch from cd49da3 to 612ea37 Compare March 25, 2026 12:51
Copy link
Copy Markdown
Collaborator

@Cali0707 Cali0707 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks @ksimon1 !

@Cali0707 Cali0707 merged commit c87c5c4 into containers:main Mar 25, 2026
8 checks passed
@manusa manusa added this to the 0.1.0 milestone Mar 25, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants