feat: adding execute method to PodmanConnection class#1813
feat: adding execute method to PodmanConnection class#1813axel7083 merged 1 commit intocontainers:mainfrom
Conversation
Signed-off-by: axel7083 <42176370+axel7083@users.noreply.github.com>
axel7083
requested review from
a team,
benoitf and
jeffmaury
as code owners
| return this.execute(connection, ['machine', 'ssh', this.getNameLegacyCompatibility(connection), ...args], options); | ||
| } | ||
|
|
||
| /** |
There was a problem hiding this comment.
I'm not sure we need the code for < 1.13 as the extension is already requiring API > 1.13.0
There was a problem hiding this comment.
We are not ?
We uses the latest api, but we don't have hard requirements on latest version, so we are in theory compatible with older version up to 1.8.
There was a problem hiding this comment.
in the catalog it says minimum 1.12 for 1.2 of ai lab
https://github.com/containers/podman-desktop-catalog/blob/gh-pages/api/extensions.json#L689
and in package.json, we consume 1.13.0 snapshot API
I'm assuming some API changes (new additions) are also missing since 1.8
so consuming 1.13 API should result in 1.13 minimal requirement
benoitf
left a comment
benoitf
left a comment
There was a problem hiding this comment.
approving as the need for the version compatibility is a separate issue
3 participants
What does this PR do?
This PR adds
executeandexecuteSSHmethod to thePodmanConnectionclass in AI Lab. The purpose is to centralize the code using the podman cli (E.g. model management, WSL Upload)The new added code takes advantages of podman-desktop/podman-desktop#8891, but still support through
Legacyfunction previous version of podman-desktop (<1.13).I split the feature in two
Screenshot / video of UI
N/A
What issues does this PR fix or reference?
Required for #1810
How to test this PR?