refactor(svelte5): migrated model select component to svelte5#2914
Merged
gastoner merged 2 commits intocontainers:mainfrom Apr 25, 2025
Merged
refactor(svelte5): migrated model select component to svelte5#2914gastoner merged 2 commits intocontainers:mainfrom
gastoner merged 2 commits intocontainers:mainfrom
Conversation
Signed-off-by: Evzen Gasta <evzen.ml@seznam.cz>
Contributor
|
Please update the PR title & description, we don't know what component is migrated |
benoitf
reviewed
Apr 23, 2025
benoitf
reviewed
Apr 23, 2025
gastoner
changed the title
Signed-off-by: Evzen Gasta <evzen.ml@seznam.cz>
Contributor
Author
axel7083
approved these changes
Apr 23, 2025
Contributor
axel7083
left a comment
axel7083
left a comment
There was a problem hiding this comment.
Codewise LGTM
(Can't test ATM, but seems okay 👍)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Migrates model select component to svelte5 syntax
Screenshot / video of UI
What issues does this PR fix or reference?
Required for #2893
How to test this PR?
Pr check