feat(locale-field-populator): default recursion depth to 5 with numeric input [ES-183]#10972
Open
Adrian Meyer (primeinteger) wants to merge 1 commit into
Open
feat(locale-field-populator): default recursion depth to 5 with numeric input [ES-183]#10972Adrian Meyer (primeinteger) wants to merge 1 commit into
Adrian Meyer (primeinteger) wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Purpose
Make the recursion depth control more flexible by raising the default to 5 and letting users pick any value from 1 to 10 instead of a fixed dropdown.
Approach
Selectwith a numericTextInput(min 0, max 10, step 1) so users can choose any depth in the supported range.MAX_REFERENCE_DEPTHfrom 3 to 5 -- new installs and unset configs now default to a deeper traversal.MIN_REFERENCE_DEPTH_OPTION/MAX_REFERENCE_DEPTH_OPTIONconstants and clamp/truncate input on change to keep stored values within bounds.