Skip to content

Modified that check burst value when run the function ValidateNetprofile #1145

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wangxf1987 wants to merge 2 commits into
base: master
Choose a base branch
from
+3 −1
Open

Modified that check burst value when run the function ValidateNetprofile #1145

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
30139f7
Modified that check burst value when run the function ValidateNetprofile
Jun 5, 2018
781dde5
Remove speaces for check burst value
Jun 5, 2018
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 3 additions & 1 deletion contivmodel/contivModel.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -9,6 +9,7 @@ import (
"errors"
log "github.com/Sirupsen/logrus"
"github.com/contiv/netplugin/objdb/modeldb"
"github.com/contiv/netplugin/utils/netutils"
"github.com/gorilla/mux"
"net/http"
"regexp"
Expand Down Expand Up @@ -3457,7 +3458,8 @@ func ValidateNetprofile(obj *Netprofile) error {
return errors.New("bandwidth string invalid format")
}

if obj.Burst > 10486 {
bwint64 := netutils.ConvertBandwidth(obj.Bandwidth)
Copy link
Copy Markdown
Contributor

@dseevr dseevr Jun 6, 2018 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Where is this function? It looks like it wasn't included in the PR, but I see it in the other PR

Copy link
Copy Markdown
Contributor Author

@wangxf1987 wangxf1987 Jun 7, 2018

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The function from the netutils.ConvertBandwidth and we use it directly()。The function will be convert the Bandwidth value, and the value type is int64.

if int64(obj.Burst) > bwint64 {
return errors.New("burst Value Out of bound")
}

Expand Down