-
-
Notifications
You must be signed in to change notification settings - Fork 4k
fix(proxy): batch Traefik outdated notifications system per team. #9262
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
Iisyourdad
wants to merge
5
commits into
coollabsio:next
Choose a base branch
from
Iisyourdad:fix/prox_email_update
base: next
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from all commits
Commits
Show all changes
5 commits
Select commit
Hold shift + click to select a range
66b4f68
fix(proxy): batch Traefik outdated notifications per team
Iisyourdad 61f37c5
Coderrabbitai fix suggestions.
Iisyourdad b44c208
fix(proxy): harden Traefik notification batching
Iisyourdad 19525e0
coderabitai comments
Iisyourdad f92187b
Preserve Traefik scan snapshots for notifications
Iisyourdad File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,48 @@ | ||
| <?php | ||
|
|
||
| namespace App\Jobs; | ||
|
|
||
| use App\Models\Team; | ||
| use App\Notifications\Server\TraefikVersionOutdated; | ||
| use Illuminate\Bus\Batchable; | ||
| use Illuminate\Bus\Queueable; | ||
| use Illuminate\Support\Fluent; | ||
| use Illuminate\Contracts\Queue\ShouldBeEncrypted; | ||
| use Illuminate\Contracts\Queue\ShouldQueue; | ||
| use Illuminate\Foundation\Bus\Dispatchable; | ||
| use Illuminate\Queue\InteractsWithQueue; | ||
| use Illuminate\Queue\SerializesModels; | ||
|
|
||
| class NotifyOutdatedTraefikServersJob implements ShouldBeEncrypted, ShouldQueue | ||
| { | ||
| use Batchable, Dispatchable, InteractsWithQueue, Queueable, SerializesModels; | ||
|
|
||
| public $tries = 3; | ||
|
|
||
| public function __construct( | ||
| public int $teamId, | ||
| public string $scanId, | ||
| public array $servers | ||
| ) | ||
| { | ||
| $this->onQueue('high'); | ||
| } | ||
|
|
||
| public function handle(): void | ||
| { | ||
| $teamServers = collect($this->servers) | ||
| ->map(fn (array $server) => new Fluent($server)) | ||
| ->values(); | ||
|
|
||
| if ($teamServers->isEmpty()) { | ||
| return; | ||
| } | ||
|
|
||
| $team = Team::find($this->teamId); | ||
| if (! $team) { | ||
| return; | ||
| } | ||
|
|
||
| $team->notify(new TraefikVersionOutdated($teamServers)); | ||
| } | ||
| } | ||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.