feat(api): add tag management endpoints for applications, databases, and services#9275
Open
kleintonno wants to merge 3 commits intocoollabsio:nextfrom
Open
feat(api): add tag management endpoints for applications, databases, and services#9275kleintonno wants to merge 3 commits intocoollabsio:nextfrom
kleintonno wants to merge 3 commits intocoollabsio:nextfrom
Conversation
…and services Add CRUD tag endpoints (GET/POST/DELETE) as sub-resources for applications, databases, and services. Add team-level GET /tags endpoint. Extend all resource creation endpoints to accept an optional tags array. Uses a shared HandlesTagsApi trait to avoid duplication across controllers. Tags are race-safe via syncWithoutDetaching(), garbage-collected when orphaned, and sanitized (strip_tags + lowercase).
Member
|
Did you manually tested the API endpoints other than running the tests? |
ShadowArcanist
added
💤 Waiting for feedback
Member
|
Please resolve merge conflicts |
Contributor
Author
|
yes, tested API endpoints with root api key and curl. worked fine merge conflicts resolved |
ShadowArcanist
removed
the
💤 Waiting for changes
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changes
Add API endpoints to manage tags on applications, databases, and services. Previously tags could only be managed through the web UI. This adds:
GET /api/v1/tags— list all tags for the current teamGET/POST/DELETE /api/v1/{applications,databases,services}/{uuid}/tags— CRUD tags per resourcetagsarray parameter on all resource creation endpoints (5 application types, 8 database types, 2 service paths)Implementation uses a shared
HandlesTagsApitrait to avoid code duplication across 3 controllers. Tags are race-safe (syncWithoutDetaching), sanitized (strip_tags+ lowercase), and garbage-collected when orphaned.Issues
Category
Preview
N/A — API-only changes, no UI modifications.
AI Assistance
If AI was used:
Testing
tests/Feature/TagApiTest.phpEnvironmentVariableUpdateApiTest,StorageApiTest) pass without regressionvendor/bin/pint --dirtypasses cleanContributor Agreement
Important