fix(ui): close CA certificate modal after successful regeneration/save#9423
Open
devrim-1283 wants to merge 1 commit intocoollabsio:nextfrom
Open
fix(ui): close CA certificate modal after successful regeneration/save#9423devrim-1283 wants to merge 1 commit intocoollabsio:nextfrom
devrim-1283 wants to merge 1 commit intocoollabsio:nextfrom
Conversation
The modal-confirmation component checks for `return true` to close the modal after form submission. Both saveCaCertificate() and regenerateCaCertificate() were missing this return value, causing the modal to stay open after a successful operation. Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changes
The CA certificate confirmation modal (both "Save" and "Regenerate") stayed open after successful operations. The
modal-confirmationcomponent'ssubmitForm()checks forreturn trueto close the modal, but neithersaveCaCertificate()norregenerateCaCertificate()returned a value on success — so the modal remained visible even though the action completed.Added
return trueto both methods on success, matching the pattern used by other Livewire components that use this modal (e.g.,Subscription\Actions,Settings\Advanced).Issues
Category
Preview
No visual changes — behavior fix. The modal now properly closes after a successful certificate save or regeneration.
AI Assistance
If AI was used:
submitForm()logic, and verify the fix pattern against other Livewire components. I reviewed and verified all changes.Testing
Contributor Agreement
Important