Skip to content

fix(ui): close CA certificate modal after successful regeneration/save#9423

Open
devrim-1283 wants to merge 1 commit intocoollabsio:nextfrom
devrim-1283:fix/ca-certificate-modal-not-closing
Open

fix(ui): close CA certificate modal after successful regeneration/save#9423
devrim-1283 wants to merge 1 commit intocoollabsio:nextfrom
devrim-1283:fix/ca-certificate-modal-not-closing

Conversation

@devrim-1283
Copy link
Copy Markdown
Contributor

Changes

The CA certificate confirmation modal (both "Save" and "Regenerate") stayed open after successful operations. The modal-confirmation component's submitForm() checks for return true to close the modal, but neither saveCaCertificate() nor regenerateCaCertificate() returned a value on success — so the modal remained visible even though the action completed.

Added return true to both methods on success, matching the pattern used by other Livewire components that use this modal (e.g., Subscription\Actions, Settings\Advanced).

Issues

  • Fixes the CA certificate regeneration/save modal not closing after successful operation

Category

  • Bug fix
  • Improvement
  • New feature
  • Adding new one click service
  • Fixing or updating existing one click service

Preview

No visual changes — behavior fix. The modal now properly closes after a successful certificate save or regeneration.

AI Assistance

  • AI was NOT used to create this PR
  • AI was used (please describe below)

If AI was used:

  • Tools used: Claude Code
  • How extensively: Used to explore codebase, identify root cause by tracing the modal-confirmation component's submitForm() logic, and verify the fix pattern against other Livewire components. I reviewed and verified all changes.

Testing

  • Navigate to Server → CA Certificate page
  • Click "Regenerate" button
  • Complete the multi-step confirmation (text + password)
  • Before: Modal stays open after successful regeneration, success toast appears behind modal
  • After: Modal closes, success toast is visible
  • Same test for "Save" button with custom certificate content

Contributor Agreement

Important

  • I have read and understood the contributor guidelines. If I have failed to follow any guideline, I understand that this PR may be closed without review.
  • I have searched existing issues and pull requests (including closed ones) to ensure this isn't a duplicate.
  • I have tested all the changes thoroughly with a local development instance of Coolify and I am confident that they will work as expected when a maintainer tests them.

The modal-confirmation component checks for `return true` to close the
modal after form submission. Both saveCaCertificate() and
regenerateCaCertificate() were missing this return value, causing the
modal to stay open after a successful operation.

Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
@ShadowArcanist ShadowArcanist changed the base branch from v4.x to next April 4, 2026 15:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant