fix(updating): avoid circular reference when rendering JSON-serialized _copier_conf variable - #2449
Merged
Merged
Conversation
…d `_copier_conf` variable
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #2449 +/- ##
=======================================
Coverage 97.26% 97.26%
=======================================
Files 55 55
Lines 6288 6299 +11
=======================================
+ Hits 6116 6127 +11
Misses 172 172
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
This was referenced Jan 22, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I've fixed a circular reference bug when rendering the JSON-serialized
_copier_confvariable during an update. According to my debugging attempt, the problem is caused by assigning more than just actual answers to thenew_worker'sdataattribute, specificallycopier._user_data.DEFAULT_DATAwhich is part ofself.answers.combinedand not filtered out. Assigning only actual answers fixes the problem. Hopefully #2376 will also resolve this problem more fundamentally. 🤞Fixes #2448.