Vanilla Patches

This list is things I want to submit to vanilla as pull requests, not bugs but features or other enhancements.

• Oil potions (and lamps?) that spontaneously ignite should be identified automatically
• The debug fuzzer should get a random item when it wishes for ESC for anything
• implement option for making statues render as ` again
  • bhaak however wants to underline them, this is pretty easy in the tty windowport since MG_STATUE already exists, but it conflicts with underlined peaceful monsters. maybe this isn't an issue though? a statue's pretty peaceful
• don't ask "Pay whom?" if standing inside a shop with an attendant shopkeeper
• make quest XL check maximum level, not current
• https://github.com/NetHack/NetHack/commit/b620ce724188ce8071d6293891134e8c36d2b009 (extremely minor)
• oracle has you ask her a question for a major consultation and does a rudimentary keyword search on oracularities (YANI #465)
• refactor: strictly separate AD_SITM and AD_SEDU; get rid of is_animal checks in stealing code
• #1474: Don't maybe give Wizards a scroll of punishment in their initial inventory.
• Refactor: replace the weird rtype and orig_rtype system with just rtype (which now is not cleared) and a 'visited' flag
• Consider flagging out init param in mksobj
• #2922: When a container is polymorphed, its contents spill out onto its square rather than vanishing. The contents do not get polymorphed from the same source. (done in xnethack, commit 940e2b2f)
• #3110: Archeologists should start the game recognizing mattocks.
• #3184: Every time a line is printed containing two adjacent spaces, the message is broken into two separate plines so that the (probably separate) statements can be broken up by the windowport better.
• suggest to devteam to make is_unique into a macro
• summon_minion will print "The foo of god appears before you" where it ought to print "A foo of god"
• Put invocation items/quest artifacts/croesus sword in the des and remove makemon special casing
• possibly POC copying text data file into install dir and read it directly
• remove STUPID and DUMB
• #1819: Shopkeepers will buy identified glass for the same few zorkmids they will buy it unidentified, rather than refusing to buy it, because it makes no sense that they buy it when the player doesn't know that it's glass and refuse to when the player does.
• Selection routine that fills any holes in the selection.
• Selection routine that does a Prim's algorithm growth of N spaces from an origin point, possibly with another parameter that controls how many neighbors a point wants to have next to it, and a parameter that keeps it restricted to same terrain
• #3061: With greasy fingers, you are incapable of playing flutes or harps, which require fine finger control. Attempting to do so just gives a message "Your greasy fingers slip on the strings/valves".
  • Possibly, attempting to play any instrument with greasy fingers makes you fumble and drop it, since even things like horns and bugles which don't require finesse still need to be held.
• yanked from closed PR #265: color grease bright blue
• yanked from closed PR #265: messages for monsters following
• add "Installation successful." to top makefile (in 2 places)
• #3772: The potion of restore ability can be used to recover lost maximum Pw. It only restores maximum Pw, not current: if your Pw is 30/80 and you previously had 100 maximum Pw, these potions will only be able to get you to 30/100. If cursed: does nothing (as usual) If uncursed: you recover one quarter the difference between your current maximum and your peak maximum, or 5 points, whichever is greater. If blessed: you recover half the difference between your current maximum and your peak maximum, or 10 points, whichever is greater.
• #3914: When spells are forgotten or retention is damaged when you suffer amnesia, the game prints a message informing you of such, akin to "You forget some of your training" for skills.
• #3931: If you are not wearing gloves, greased rings slip off your fingers as if you had greasy fingers.
• pet summaries in dumplog, show hp/hpmax, level, species, name, items, maybe hunger status and a general description of tameness
• #4723: Monsters that can phase should be able to escape bear traps without resistance. If they are solid like xorns, they should still take damage, but they should logically be able to just phase out of the trap.
• #4928: There is a problem when examining the circumstances of someone's death in a dumplog: when the player does something that prompts for a direction, the action they are trying to do does not appear in any messages except those that result from the action, so if it doesn't produce any useful messages, this remains unclear.
  • unless 3.7 did this already?
• #5057: If you are polymorphed into a fire elemental, there should be a way to burn through a closed door. Probably via force-fighting the door while bare-handed.
• #4529: If the player is about to be hit with a death ray and has not yet expended their saving grace, the saving grace protects them from the instadeath. Probably by converting the ray hit (and any reflections from the same ray?) into a miss; otherwise the game would have to explain why a non-resistant character got hit by a death ray and failed to die.
• #4551: Expose some additional information to Lua special level files in order to let level designers put sanity checks and impossibles into their code which won't be hit in the course of "normal" gameplay. This could be any combination of the following:
• #4979: If you turn to stone by hitting a cockatrice with a bare-handed attack, the death reason should not be "petrified by a cockatrice" which makes it sound like the cockatrice's attack did you in, but should instead be "petrified by punching a cockatrice bare-handed".