Bug fix in MP3 and FLAC compute length on TTSDataset#3092
Merged
Conversation
akx
reviewed
Oct 31, 2023
akx
reviewed
Nov 7, 2023
akx
left a comment
akx
left a comment
Contributor
There was a problem hiding this comment.
Nice! I guess a test that checks that each of the 3 ostensibly supported formats actually works (both get_audio_size and loading-wise) would be useful...
Contributor
Author
Yeah, I added a unit test that loads with all supported audio formats. And also call |
Edresson
changed the title
WeberJulian
approved these changes
Nov 29, 2023
Contributor
Author
|
Looks like the Trainer PR coqui-ai/Trainer#131 brokes the aux tests |
Edresson
force-pushed
the
mp3_len_fix
branch
from
75066bb to
02ff6f4
Compare
Co-authored-by: Aarni Koskela <akx@iki.fi>
Edresson
force-pushed
the
mp3_len_fix
branch
from
49140dd to
e741cab
Compare
Pranjalya
added a commit
to Pranjalya/TTS
that referenced
this pull request
Dec 29, 2023
Bug fix in MP3 and FLAC compute length on TTSDataset (coqui-ai#3092)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.