Draft: fix aux tests after Trainer update#3390
Closed
eginhard wants to merge 4 commits into
Closed
Conversation
This was referenced Dec 8, 2023
Member
|
I reverted the PR in Trainer, we don't need to pin it here. |
Contributor
Author
|
@erogol Could you reopen? This PR contains the fixes required in TTS after merging coqui-ai/Trainer#135 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Requires reverting coqui-ai/Trainer#133 and making another Trainer release.
I've temporarily pinned Trainer to 0.0.33 because that includes coqui-ai/Trainer#133, so that we can already see if CI passes. Afterwards, I'd pin it to
>=0.0.35.