dlopen: report the dlerror from GetHandle - #527
Open
vtushar06 wants to merge 1 commit into
Open
Conversation
GetHandle() never called dlerror() so a failed dlopen() only ever produced the static ErrSoNotFound, with no way to tell why the library did not load. Signed-off-by: Tushar Verma <tusharmyself06@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I ran into this from the podman side - the API returns
unable to open a handle to the libraryand there is no way to tell why libsystemd did not load.GetSymbolPointerandClosehave reporteddlerror()since #431,GetHandleis the one that never calls it.The case I care about is when the file is present and dlopen still refuses, so "not found" is misleading:
ErrSoNotFoundis still wrapped soerrors.Iskeeps working, and the bare error is kept when dlopen gives no reason.runtime.LockOSThreadfor the same reason as #431.The test fails on current main:
Context, if useful: podman-container-tools/podman#29528