fix: update index calculation for x-axis#2701
Open
kofmania wants to merge 3 commits into
Open
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
Fixes incorrect slice buffer indexing for sagittal (YZ) slice extraction in VoxelManager.getSliceData, which was causing wrong images when generating slice data.
Changes:
- Adjusted the linear index calculation used when writing into the
sliceDatabuffer forslicePlane === 0(YZ plane).
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Collaborator
wayfarer3130
left a comment
There was a problem hiding this comment.
Generally looks ok, can you create the requested unit test and document the return function?
Contributor
There was a problem hiding this comment.
Pull request overview
Copilot reviewed 2 out of 2 changed files in this pull request and generated no new comments.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Context
Generating image slice(sagittal plane) data return wrong image in voxelManager.getSliceData
Changes & Results
Update index calculation code
file
packages/core/src/utilities/VoxelManager.tscurrent
new
Testing
Checklist
PR
semantic-release format and guidelines.
Code
etc.)
Public Documentation Updates
additions or removals.
Tested Environment