Beta#2748
Open
wayfarer3130 wants to merge 33 commits into
Open
Conversation
* bump version * bump version [BUMP BETA MAJOR]
Update beta 20260313
Update beta 20260317 The ohif downstream only has the specific issues that are known to occur on that backend, so merging
merge: cs3d 20260413
Merge/cs3d 20260423
Merge/20260427
Merge/main beta 20260506
* feat: Add metadata module to single-source metadata
* Revert some of hte changes to dicom image loader in favour of deprecation
* Undo change
* Move unit tests to metadata package
* Revert changes to adapters
* Revert unneeded changes
* Update metadata module to use AsyncDicomListener format
* fix: Add unit test
* Add metadata provider and init for the new metadata function
* Split module lists
* update metadata versoin
* Move audit to end so build steps are viewable
* fix: Audit last
* fix lock file mismatch
* fix: metadata reference
* fix: Link to metadata
* fix: Move audit to a single build to allow overall PR status
Previously the audit happened early and multiple times, causing issues
when the audit failures were unrelated to other changes.
* fix: Unused components, add ecg module
* Remove subdirectory import
* fix: ecg module
* Remove unused lower camel case reader
* Switch new/old flag to be useLegacyMetadataProvider
* Add metadata module for github builds
* useLegacyMetadataProvider for the karma tests needing it
* Add legacy module name
* PR comments
* fix: Wado URI test
* Update version
* Missing PR rename issue
* Fix init/register options to allow registering new provider
This explains the differences between the legacy/default metadata
provider and the data loaders themselves, which still need
registering.
* Add rebuild:canvas command to fix missing canvas
* fix: Update way that loadImage functions with naturalized data
* Cleaner listener design/setup and pas (more) tests
* fix: loadImage with metadata module
* fix: Transfer syntax return as string
* fix: Wrong load image was getting used
* Update the register to clear data
* Store worker log to loglevel
* fix: Various karma tests
* fix: Remaining karma issues
* fix: Scaling data unit tests weren't running correctly
* Use fixed page size to make tests run consistently.
* Set size for consistency
* docusaurus build issues
* Build fixes
* Version fix
* Update to include metadata module
* Include metadata module in circleci config
* fix: Build when linked
* fix: workspace dependency to allow yarn 1.x
* Update package module for adapters build
* Try to fix adapters build issue
* Export suv scaling factor
* Update bun version to push an update
* Link suv module specifically
* fix: Merge issues
* bun lock
* Make node directory if it doesn't exist
* fix: Add migration guide and remove prebuild:esm
* Rename natural to naturalizedMetadata
* More renames natural => naturalized
* PR review comments
* Push test versoin
* Run against master instead of beta
* Rerun tests
* fix: Allow lower ohif_ref for reference
* Invalid image position for PT and some positions with parent position
* Kick updated build
* PR comments to use a separate pipeline for the add handling
* fix: Aspect ratio - merge had gone bad and undo missed changes
* fix: Unintended merge
* Only remove imageId prefix if there are at least two schemes
* PR review comment fixes
* Create @corenrstonejs/utils package with initial contents
* fix: install
* Use load local instead of upload
* Fix karma tests
* fix: Build issues
* fix: Types on toNumber
* fix: ohif-downstream to use build:esm
* toNumber
* Force retest
* Change to allow 120 minutes for CS3D playwright tests
* Update retries to match OHIF
* Upload playwright results on failure
* fix: Add utils path
* Rename addPart10Instance
* Remove cache warm up in utils
* Fix function rename
* PR comments - use enum values instead of literals.
- Keep beta version 5.0.0-beta.2 for all package versions - Incorporate 4.22.8 (security) and 4.22.9 (angle tool fix) changelog entries - Update @babel/preset-env to 7.29.5 from main security update - Retain @babel/plugin-transform-typescript 7.28.6 from beta Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
Merge/main 20260515 into beta
…60526 Update/beta from main 20260526 Still has a couple of playwright bugs to resolve, but these will be done in the viewports pr
* feat: pnpm 11 build/install for cs3d * Format check runs at root level rather than in each package * Enable corepack detection of pnpm version * Fix audit issue * ohif-downstream build issue * Update to beta.3 for pnpm * Update beta 3 in pnpm lock * Re-run test on updated OHIF * Fix pnpm build based on merge commit * Fix link/unlik * Fixes for linking * fix cs3d link with ohif * ci: pin Node 24 and bump pnpm to 11.4.0 playwright.yml's matrix had regressed to Node 20 during the beta merge, but pnpm 11 requires Node >=22.13 (uses node:sqlite), so installs crashed with ERR_UNKNOWN_BUILTIN_MODULE. Restore Node 24 everywhere and move pnpm 11.1.1 -> 11.4.0 across all workflows and packageManager. Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com> * chore: drop exact packageManager pin, rely on engines pnpm>=11 The packageManager: pnpm@11.4.0 pin forced pnpm's precise-version auto-switch, which broke commits for anyone whose local pnpm couldn't fetch that exact build. engines.pnpm ">=11" is sufficient; CI still pins 11.4.0 via pnpm/action-setup. Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com> * chore: restore packageManager pnpm pin for nested-repo corepack CS3D lives inside the OHIF repo, whose package.json pins packageManager: yarn. With corepack enabled, dropping CS3D's own packageManager field makes corepack walk up and resolve yarn for CS3D, breaking the pnpm-based husky hook. Pin pnpm here so corepack uses (and auto-fetches) pnpm for this workspace. Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com> * fix(ohif-downstream): install OHIF with bun, not pnpm OHIF is a bun/yarn project checked out inside this pnpm workspace. Installing it with pnpm walks up to this repo's pnpm-workspace.yaml (node-linker: hoisted) and produces a mixed node_modules where OHIF's jest and CS3D's jest copies get tangled, so jest-runner resolves to a different instance than @jest/core -> "Cannot read properties of undefined (reading 'leakDetector')". Install/run the OHIF side with bun (its native package manager) so it gets a self-contained node_modules. Adds a Set up Bun step; CS3D's own install/build stay on pnpm. Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com> * Update bun lock * frozen workfiles * Move frozen lockfile flag to pnpm-workspace.yaml * lock * Rerun build, resetting ohif-downstream to default * fix: unit test run * Fix chrome headless run for karma tests * Update tmp 0.2.6 to resolve the high severity issue --------- Co-authored-by: Claude Opus 4.7 (1M context) <noreply@anthropic.com> Co-authored-by: Joe Boccanfuso <joe.boccanfuso@radicalimaging.com>
![claude[bot]](https://avatars.githubusercontent.com/in/1236702?s=60&v=4){kind=small}
There was a problem hiding this comment.
Claude Code Review
This repository is configured for manual code reviews. Comment @claude review to trigger a review and subscribe this PR to future pushes, or @claude review once for a one-time review.
Tip: disable this comment in your organization's Code Review settings.
|
Important Review skippedToo many files! This PR contains 296 files, which is 146 over the limit of 150. To get a review, narrow the scope: ⚙️ Run configurationConfiguration used: defaults Review profile: CHILL Plan: Pro Plus Run ID: ⛔ Files ignored due to path filters (4)
📒 Files selected for processing (296)
You can disable this status message by setting the Use the checkbox below for a quick retry:
✨ Finishing Touches🧪 Generate unit tests (beta)
Comment |
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
Comment on lines
+12
to
+84
| timeout-minutes: 120 | ||
| runs-on: self-hosted | ||
| strategy: | ||
| fail-fast: false | ||
| max-parallel: 3 | ||
| matrix: | ||
| node-version: [20] | ||
| include: | ||
| - node-version: 24 | ||
| mode: legacy | ||
| run_args: '--project=chromium' | ||
| collect_coverage: true | ||
| - node-version: 24 | ||
| mode: compatibility | ||
| run_args: '--compat --project=chromium' | ||
| collect_coverage: false | ||
| - node-version: 24 | ||
| mode: next | ||
| run_args: '--next --project=chromium' | ||
| collect_coverage: false | ||
| name: Playwright (${{ matrix.mode }}) | ||
| steps: | ||
| - uses: actions/checkout@v4 | ||
| - uses: oven-sh/setup-bun@v2 | ||
| - uses: pnpm/action-setup@v4 | ||
| with: | ||
| bun-version: 1.2.23 | ||
| version: 11.4.0 | ||
| - uses: actions/setup-node@v4 | ||
| with: | ||
| node-version: ${{ matrix.node-version }} | ||
| cache: 'pnpm' | ||
| - name: Install dependencies | ||
| run: bun install --frozen-lockfile | ||
| # - name: Install Playwright browsers | ||
| # run: bun x playwright install-deps chromium | ||
| run: pnpm install --frozen-lockfile | ||
| - name: Install Playwright browsers | ||
| run: pnpm exec playwright install chromium | ||
| - name: Run Playwright tests | ||
| env: | ||
| CI: true | ||
| COVERAGE: ${{ matrix.collect_coverage && 'true' || '' }} | ||
| PLAYWRIGHT_HTML_OPEN: never | ||
| run: | | ||
| export NODE_OPTIONS="--max_old_space_size=10192" | ||
| bun run test:e2e:coverage | ||
| if [ "${{ matrix.collect_coverage }}" = "true" ]; then | ||
| pnpm exec nyc --reporter=html ./scripts/run-playright.sh ${{ matrix.run_args }} | ||
| else | ||
| ./scripts/run-playright.sh ${{ matrix.run_args }} | ||
| fi | ||
| - name: Upload Playwright report and test results | ||
| if: failure() | ||
| uses: actions/upload-artifact@v4 | ||
| with: | ||
| name: playwright-results-${{ github.sha }} | ||
| if-no-files-found: warn | ||
| path: | | ||
| tests/playwright-report/ | ||
| tests/test-results/ | ||
| retention-days: 7 | ||
| - name: create the coverage report | ||
| if: ${{ matrix.collect_coverage }} | ||
| run: | | ||
| bun nyc report --reporter=lcov --reporter=text | ||
| pnpm exec nyc report --reporter=lcov --reporter=text | ||
| - name: Upload the coverage report to GitHub Actions Artifacts | ||
| if: ${{ !cancelled() }} | ||
| if: ${{ !cancelled() && matrix.collect_coverage }} | ||
| uses: actions/upload-artifact@v4 | ||
| with: | ||
| name: coverage-report-pr | ||
| path: coverage | ||
| retention-days: 7 | ||
| - name: Upload Playwright reports | ||
| if: ${{ !cancelled() }} | ||
| uses: actions/upload-artifact@v4 | ||
| with: | ||
| name: playwright-report-${{ matrix.mode }} | ||
| path: reports/*playwright | ||
| retention-days: 7 |
Collaborator
Author
|
This also needs: |
| @@ -162,8 +209,10 @@ | |||
| ); | |||
| shell.ShellString(conf).to(webpackConfigPath); | |||
|
|
|||
| shell.exec(`rspack build --config ${webpackConfigPath}`); | |||
| shell.exec(`${rspackBin} build --config ${webpackConfigPath}`); | |||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
OHIF_REF: ohifohifupdateplaywightimgaes
Context
Merge cs3d 5.x beta branch to main
** MERGE this, do not squash to preserve history/merges from main **
Changes & Results
Testing
Checklist
PR
semantic-release format and guidelines.
Code
etc.)
Public Documentation Updates
additions or removals.
Tested Environment