Skip to content

fix(ibc): use cache context in ibc timeout callback gas accounting #1063

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
mmsqe wants to merge 1 commit into
base: main
Choose a base branch
from
+2 −1
Open

fix(ibc): use cache context in ibc timeout callback gas accounting #1063

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -44,6 +44,7 @@
- [\#967](https://github.com/cosmos/evm/pull/967) Fix return value of erc20 ibcv2 middleware to properly reflect application success and middleware failure.
- [\#992](https://github.com/cosmos/evm/pull/992) Respect the provided `gasCap` in `CallEVMWithData` instead of always used the default cap.
- [\#993](https://github.com/cosmos/evm/pull/993) Enforce `src_callback` contract address to match the packet sender for IBC acknowledgement and timeout callbacks to prevent arbitrary contract execution.
- [\#1062](https://github.com/cosmos/evm/pull/1062) Use cache context in timeout ibc callback gas accounting.

## v0.6.0

Expand Down
2 changes: 1 addition & 1 deletion x/ibc/callbacks/keeper/keeper.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -425,7 +425,7 @@ func (k ContractKeeper) IBCOnTimeoutPacketCallback(
WithGasMeter(evmtypes.NewInfiniteGasMeterWithLimit(cbData.CommitGasLimit))
stateDB := statedb.New(cachedCtx, k.evmKeeper, statedb.NewEmptyTxConfig())

res, err := k.evmKeeper.CallEVM(ctx, stateDB, callbacksabi.ABI, sender, contractAddr, true, false, math.NewIntFromUint64(cachedCtx.GasMeter().GasRemaining()).BigInt(), "onPacketTimeout",
res, err := k.evmKeeper.CallEVM(cachedCtx, stateDB, callbacksabi.ABI, sender, contractAddr, true, false, math.NewIntFromUint64(cachedCtx.GasMeter().GasRemaining()).BigInt(), "onPacketTimeout",
packet.GetSourceChannel(), packet.GetSourcePort(), packet.GetSequence(), packet.GetData())
if err != nil {
return errorsmod.Wrapf(types.ErrCallbackFailed, "EVM returned error: %s", err.Error())
Expand Down
Loading