fix: add nil check for OnTxStart before calling tracer hook#1078
Open
Bue-von-hon wants to merge 1 commit intocosmos:mainfrom
Open
fix: add nil check for OnTxStart before calling tracer hook#1078Bue-von-hon wants to merge 1 commit intocosmos:mainfrom
Bue-von-hon wants to merge 1 commit intocosmos:mainfrom
Conversation
Calling vmCfg.Tracer.OnTxStart without a nil check causes a panic when a custom tracer does not implement the OnTxStart field. Added a nil guard consistent with the existing OnTxEnd check. Closes cosmos#209
Greptile SummaryThis PR adds a nil guard for
Confidence Score: 5/5
Important Files Changed
Last reviewed commit: e74482a |
vladjdk
approved these changes
Mar 17, 2026
Author
|
Please review. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Calling vmCfg.Tracer.OnTxStart without a nil check causes a panic when a custom tracer does not implement the OnTxStart field. Added a nil guard consistent with the existing OnTxEnd check.
Closes #209
Author Checklist
mainbranch