Skip to content

Fix CosmoScout atmosphere model#425

Open
JonasGilg wants to merge 2 commits intomainfrom
feature/fix-atmospheres
Open

Fix CosmoScout atmosphere model#425
JonasGilg wants to merge 2 commits intomainfrom
feature/fix-atmospheres

Conversation

@JonasGilg
Copy link
Copy Markdown
Member

When loading the CosmoScoutVR atmosphere model a "string too long" exception was thrown. This fixes the error, as there was a typo in the loading logic.

This PR still needs work, as the atmosphere now renders only black.

@JonasGilg JonasGilg self-assigned this Mar 4, 2026
@JonasGilg JonasGilg added bug Something isn't working csp-atmospheres labels Mar 4, 2026
@coveralls
Copy link
Copy Markdown

coveralls commented Mar 4, 2026

Pull Request Test Coverage Report for Build 22664680975

Details

  • 0 of 1 (0.0%) changed or added relevant line in 1 file are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 1.188%

Changes Missing Coverage Covered Lines Changed/Added Lines %
plugins/csp-atmospheres/src/models/cosmoscout/Model.cpp 0 1 0.0%
Totals Coverage Status
Change from base Build 22664546685: 0.0%
Covered Lines: 201
Relevant Lines: 16915

💛 - Coveralls

Benman2785 added a commit to Benman2785/cosmoscout-vr that referenced this pull request Mar 19, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Something isn't working csp-atmospheres

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants