Remove sed commands that broke Dockerfile#577
Merged
Conversation
When environment.yml's python and pip version strings changed, the embedded greps no longer returned any value, leading to sed commands that deleted all lines of environment.yml, resulting in the error 'libmamba No target prefix specified' which broke the docker build.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When environment.yml's python and pip version strings changed, the embedded greps no longer returned any value, leading to sed commands that deleted all lines of environment.yml, resulting in the error 'libmamba No target prefix specified' which broke the docker build. (refs #573)