feat: handle quotes without defined receiver#7259
Open
limitofzero wants to merge 80 commits intodevelopfrom
Open
feat: handle quotes without defined receiver#7259limitofzero wants to merge 80 commits intodevelopfrom
limitofzero wants to merge 80 commits intodevelopfrom
Conversation
# Conflicts: # apps/cowswap-frontend/package.json # apps/explorer/package.json # apps/sdk-tools/package.json # apps/widget-configurator/package.json # libs/analytics/package.json # libs/balances-and-allowances/package.json # libs/common-const/package.json # libs/common-hooks/package.json # libs/common-utils/package.json # libs/core/package.json # libs/currency/package.json # libs/ens/package.json # libs/events/package.json # libs/multicall/package.json # libs/permit-utils/package.json # libs/tokens/package.json # libs/types/package.json # libs/ui/package.json # libs/wallet/package.json # libs/widget-lib/package.json # pnpm-lock.yaml
…tc-sol # Conflicts: # apps/cowswap-frontend/package.json # apps/explorer/package.json # apps/sdk-tools/package.json # apps/widget-configurator/package.json # libs/analytics/package.json # libs/balances-and-allowances/package.json # libs/common-const/package.json # libs/common-hooks/package.json # libs/common-utils/package.json # libs/core/package.json # libs/currency/package.json # libs/ens/package.json # libs/events/package.json # libs/multicall/package.json # libs/permit-utils/package.json # libs/tokens/package.json # libs/types/package.json # libs/ui/package.json # libs/wallet/package.json # libs/widget-lib/package.json # pnpm-lock.yaml
limitofzero
changed the title
# Conflicts: # apps/cowswap-frontend/package.json # apps/explorer/package.json # apps/sdk-tools/package.json # apps/widget-configurator/package.json # libs/analytics/package.json # libs/balances-and-allowances/package.json # libs/common-const/package.json # libs/common-hooks/package.json # libs/common-utils/package.json # libs/core/package.json # libs/currency/package.json # libs/ens/package.json # libs/events/package.json # libs/multicall/package.json # libs/permit-utils/package.json # libs/tokens/package.json # libs/types/package.json # libs/ui/package.json # libs/wallet/package.json # libs/widget-lib/package.json # pnpm-lock.yaml
limitofzero
force-pushed
the
feat/handle-quotes-without-receiver
branch
from
a28c15f to
929adb7
Compare
# Conflicts: # apps/cowswap-frontend/src/modules/trade/containers/TradeWidget/TradeWidgetForm.tsx # apps/cowswap-frontend/src/modules/tradeQuote/hooks/useQuoteParamsRecipient.test.ts # apps/cowswap-frontend/src/modules/tradeQuote/hooks/useQuoteParamsRecipient.ts
Contributor
Author
|
@elena-zh thank you, could u pls check again, I added fallback to default recipient if user enter invalid one |
elena-zh
requested changes
Apr 17, 2026
Contributor
elena-zh
left a comment
elena-zh
left a comment
There was a problem hiding this comment.
Hey @limitofzero , changes almost LGTM!
However, now the banner is not displayed for a regular bridge in SC wallets, that is why the main button is disabled
Could you please fix it?
Besides. there is 1 nitpick: sometimes it takes too long to load the quote, and in the end I see this error in stead of a 'wrong recipient' message/ Could you please double check whether it is an issue on Near side or on ours?
Thanks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Add a default address for btc/sol bridging to show a quote until a user set a receiver address.
To Test
Summary by CodeRabbit
Bug Fixes
Behavior/UI
Tests