feat: enforce https when using postMessage#7307
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
|
Important Review skippedDraft detected. Please check the settings in the CodeRabbit UI or the ⚙️ Run configurationConfiguration used: Repository UI Review profile: CHILL Plan: Pro Run ID: You can disable this status message by setting the Use the checkbox below for a quick retry:
✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
| } | ||
|
|
||
| contentWindow.postMessage(postPayload, targetOrigin) | ||
| // Old versions of the widget will still have '*' as target origin, so we fallback to the default origin. Integrations using a custom `baseUrl` will break. |
There was a problem hiding this comment.
Here we DO need the fallback for backwards compatibility.
Summary
https(except forlocalhost).httpsfor hooks dApps and add error handling (https://github.com/cowprotocol/cowswap/pull/7307/changes#diff-88dbd9af77d6295c9f032c680f453796c5cc7149659998b18e8ac79e5ecfca72R54)common-utils: https://github.com/cowprotocol/cowswap/pull/7307/changes#diff-7380b3a5b4b4a44e8350ee24c3b2b53e6dc152e623c61643aa9edf1be8b49670R1To Test
aboutBackground
Optional: Give background information for changes you've made, that might be difficult to explain via comments