Skip to content

Fix #155: fix wasm builds #156

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
leftibot wants to merge 3 commits into
base: main
Choose a base branch
from
Open

Fix #155: fix wasm builds #156

Changes from 2 commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
5fddb4b
Fix #155: switch WASM builds from legacy Asyncify to JSPI
leftibot May 2, 2026
2521055
Address review: remove WASM cmake-script regression test
leftibot May 2, 2026
cd295c0
Address review: switch WASM EH to -fexceptions, restore Asyncify
leftibot May 2, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 5 additions & 5 deletions cmake/Emscripten.cmake
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -42,8 +42,6 @@ if(EMSCRIPTEN)
"Initial WASM memory in bytes (default: 32MB)")
set(myproject_WASM_PTHREAD_POOL_SIZE "4" CACHE STRING
"Pthread pool size for WASM builds (default: 4)")
set(myproject_WASM_ASYNCIFY_STACK_SIZE "65536" CACHE STRING
"Asyncify stack size in bytes (default: 64KB)")

# For Emscripten WASM builds, FTXUI requires pthreads and native exception handling
# Set these flags early so they propagate to all dependencies
Expand Down Expand Up @@ -89,9 +87,11 @@ function(myproject_configure_wasm_target target)
"-sUSE_PTHREADS=1"
"-sPROXY_TO_PTHREAD=1"
"-sPTHREAD_POOL_SIZE=${myproject_WASM_PTHREAD_POOL_SIZE}"
# Enable asyncify for emscripten_sleep and async operations
"-sASYNCIFY=1"
"-sASYNCIFY_STACK_SIZE=${myproject_WASM_ASYNCIFY_STACK_SIZE}"
# Enable JSPI (JavaScript Promise Integration) for emscripten_sleep
# and other async operations. JSPI is the modern replacement for
# legacy Asyncify (-sASYNCIFY=1) and, unlike Asyncify, is compatible
# with native WebAssembly exception handling (-fwasm-exceptions).
"-sJSPI=1"
# Memory configuration
"-sALLOW_MEMORY_GROWTH=1"
"-sINITIAL_MEMORY=${myproject_WASM_INITIAL_MEMORY}"
Expand Down
Loading