Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #236
What
Extracts the repeated five-line TTL-extension boilerplate into a new
storagemodule, eliminating four copy-paste sites and fixing the missing instance-TTL bump incancel_circle.New
contracts/sharibo/src/storage.rsload_circle(env, id)— load aCirclefrom persistent storage, panic withCircleNotFoundif absent.save_circle(env, id, circle)— persist aCircle, extend its persistent TTL, and bump the instance TTL.bump_instance(env)— extend instance TTL (used internally bysave_circle).LEDGER_THRESHOLDandLEDGER_EXTEND_TOconstants moved here with their full doc comments.Changes to
lib.rsenv.storage().persistent().get(...).unwrap_or_else(...)calls withload_circle.set / extend_ttl / extend_ttltriplets withsave_circle.cancel_circlenow also bumps the instance TTL (it was missing theenv.storage().instance().extend_ttl(...)call).LEDGER_THRESHOLDandLEDGER_EXTEND_TOare no longer duplicated inlib.rs.Verification
cargo testshould still pass (21 tests).cargo build --target wasm32-unknown-unknown --releaseshould succeed.