Skip to content

[8786] Fix left panel collapsing on form reload #8851

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
jvega190 wants to merge 1 commit into
base: develop
Choose a base branch
from
Open

[8786] Fix left panel collapsing on form reload #8851

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
24 changes: 18 additions & 6 deletions studio-ui/ui/app/src/components/FormsEngine/components/FormLayout.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -20,6 +20,7 @@ import React, {
ReactNode,
type RefCallback,
RefObject,
useCallback,
useContext,
useImperativeHandle,
useLayoutEffect
Expand All @@ -35,7 +36,7 @@ import { useAtomValue, useStore as useJotaiStore } from 'jotai/index';
import { UIBlocker } from '../../UIBlocker';
import { getScrollContainer } from '../lib/formUtils';
import { stackFormCountAtom } from '../lib/formConsts';
import { createStore, useAtom } from 'jotai';
import { createStore } from 'jotai';
import { getMarginSxProps } from '../../../utils/ui';
import { useResizeObserver } from '../../../hooks/useResizeObserver';

Expand Down Expand Up @@ -79,7 +80,8 @@ export const FormLayout = forwardRef<HTMLDivElement, FormLayoutProps>(function (
const { api: contextApi } = useContext(StableGlobalContext);
const { state: stateCache, atoms } = useContext(StableFormContext);
const { id } = useContext(ItemMetaContext);
const [isLargeContainer, setIsLargeContainer] = useAtom(atoms.isLargeContainer);
const isLargeContainerAtom = atoms.isLargeContainer;
const isLargeContainer = useAtomValue(isLargeContainerAtom);

useImperativeHandle(ref, () => containerRef.current);

Expand Down Expand Up @@ -137,15 +139,25 @@ export const FormLayout = forwardRef<HTMLDivElement, FormLayoutProps>(function (
}
}, [containerRef, hasStackedForms]);

// Resize observer attached to the [scroll] container
useResizeObserver(containerRef, () => {
const measureContainer = useCallback(() => {
const container = containerRef.current;
if (!container) return;
const rect: DOMRect = container.getBoundingClientRect();
const width = rect.width;
container.style.setProperty('--container-width', `${width}px`);
container.style.setProperty('--container-height', `${rect.height}px`);
setIsLargeContainer(width >= theme.breakpoints.values.lg);
});
store.set(isLargeContainerAtom, width >= theme.breakpoints.values.lg);
}, [containerRef, isLargeContainerAtom, store, theme.breakpoints.values.lg]);

// The form may swap in a brand new set of atoms without remounting (e.g. reloading after saving an amend, or
// after a rename). The resize observer won't fire for a container that hasn't changed size, so the new
// `isLargeContainer` atom would keep its default and the table of contents would render collapsed.
useLayoutEffect(() => {
measureContainer();
}, [measureContainer]);

// Resize observer attached to the [scroll] container
useResizeObserver(containerRef, measureContainer);

return (
<Box
Expand Down