[7418] s3 and wevdav datasources - #8870
Draft
jvega190 wants to merge 6 commits into
Draft
Conversation
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Path: .coderabbit.yaml Review profile: CHILL Plan: Pro Run ID: 📒 Files selected for processing (19)
💤 Files with no reviewable changes (1)
WalkthroughThe Forms Engine now supports external S3 and WebDAV browse and upload flows. Shared request, service, and dialog wiring is included. Remote stubs are replaced with concrete generic, image, and video data-source modules. ChangesExternal asset flow
Estimated code review effort: 3 (Moderate) | ~25 minutes Sequence Diagram(s)sequenceDiagram
participant DataSource as S3/WebDAV data source
participant Action as External action factory
participant Services as DataSourceServices
participant Dialog as External asset dialog
DataSource->>Action: create browse or upload action
Action->>Services: pass expanded path, profile, and filters
Services->>Dialog: open external asset dialog
Dialog-->>Services: return selections, upload result, or cancellation
Services-->>Action: return array, result, or null
Action-->>DataSource: map result to item or asset selection
Possibly related PRs
Suggested reviewers: 🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✨ Finishing Touches🧪 Generate unit tests (beta)
Comment |
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 1
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Inline comments:
In `@studio-ui/ui/app/src/components/FormsEngine/dataSources/moduleHelpers.ts`:
- Around line 302-340: Forward the configured mimeTypes allowlist from
createExternalBrowseAction into the browseExternalAssets request. Add
mimeTypes?: string[] to DataSourceBrowseExternalRequest in
studio-ui/ui/app/src/components/FormsEngine/dataSources/types.ts#L88-L96, and
retain the existing MIME allowlist handling in
studio-ui/ui/app/src/components/FormsEngine/dataSources/modules/imgS3Repo.ts#L34-L42
and
studio-ui/ui/app/src/components/FormsEngine/dataSources/modules/imgWebDAVRepo.ts#L34-L42
after request-level filtering.
🪄 Autofix
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: Path: .coderabbit.yaml
Review profile: CHILL
Plan: Pro
Run ID: e166a56a-79ab-405a-96ab-3a38a8ee0313
📒 Files selected for processing (19)
studio-ui/docs/type-builder-forms-engine.mdstudio-ui/ui/app/src/components/FormsEngine/dataSources/moduleHelpers.tsstudio-ui/ui/app/src/components/FormsEngine/dataSources/modules/imgS3Repo.tsstudio-ui/ui/app/src/components/FormsEngine/dataSources/modules/imgS3Upload.tsstudio-ui/ui/app/src/components/FormsEngine/dataSources/modules/imgWebDAVRepo.tsstudio-ui/ui/app/src/components/FormsEngine/dataSources/modules/imgWebDAVUpload.tsstudio-ui/ui/app/src/components/FormsEngine/dataSources/modules/remoteStubs.tsstudio-ui/ui/app/src/components/FormsEngine/dataSources/modules/s3Repo.tsstudio-ui/ui/app/src/components/FormsEngine/dataSources/modules/s3Upload.tsstudio-ui/ui/app/src/components/FormsEngine/dataSources/modules/videoS3Repo.tsstudio-ui/ui/app/src/components/FormsEngine/dataSources/modules/videoS3Upload.tsstudio-ui/ui/app/src/components/FormsEngine/dataSources/modules/videoWebDAVRepo.tsstudio-ui/ui/app/src/components/FormsEngine/dataSources/modules/videoWebDAVUpload.tsstudio-ui/ui/app/src/components/FormsEngine/dataSources/modules/webDavRepo.tsstudio-ui/ui/app/src/components/FormsEngine/dataSources/modules/webDavUpload.tsstudio-ui/ui/app/src/components/FormsEngine/dataSources/services.tsstudio-ui/ui/app/src/components/FormsEngine/dataSources/types.tsstudio-ui/ui/app/src/components/FormsEngine/lib/controlHelpers.tsxstudio-ui/ui/app/src/env/studioUI.ts
💤 Files with no reviewable changes (1)
- studio-ui/ui/app/src/components/FormsEngine/dataSources/modules/remoteStubs.ts
Contributor
Author
|
@coderabbitai can you check if everything looks good? Please give it a final review before I hand over for human review |
|
✅ Action performedFull review finished. |
There was a problem hiding this comment.
Actionable comments posted: 1
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Inline comments:
In `@studio-ui/ui/app/src/components/FormsEngine/lib/controlHelpers.tsx`:
- Around line 267-308: Forward request.mimeTypes through
createDataSourceServices and showBrowseExternalAssetDialog into
BrowseExternalAssetDialog, adding it to BrowseExternalAssetDialogProps and the
container props. Filter fetched external files by mimeTypes before rendering or
allowing selection, while preserving the existing type filter behavior.
🪄 Autofix
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: Path: .coderabbit.yaml
Review profile: CHILL
Plan: Pro
Run ID: 30d67fc1-f838-49dd-b0ce-7f8cedda6b12
📒 Files selected for processing (19)
studio-ui/docs/type-builder-forms-engine.mdstudio-ui/ui/app/src/components/FormsEngine/dataSources/moduleHelpers.tsstudio-ui/ui/app/src/components/FormsEngine/dataSources/modules/imgS3Repo.tsstudio-ui/ui/app/src/components/FormsEngine/dataSources/modules/imgS3Upload.tsstudio-ui/ui/app/src/components/FormsEngine/dataSources/modules/imgWebDAVRepo.tsstudio-ui/ui/app/src/components/FormsEngine/dataSources/modules/imgWebDAVUpload.tsstudio-ui/ui/app/src/components/FormsEngine/dataSources/modules/remoteStubs.tsstudio-ui/ui/app/src/components/FormsEngine/dataSources/modules/s3Repo.tsstudio-ui/ui/app/src/components/FormsEngine/dataSources/modules/s3Upload.tsstudio-ui/ui/app/src/components/FormsEngine/dataSources/modules/videoS3Repo.tsstudio-ui/ui/app/src/components/FormsEngine/dataSources/modules/videoS3Upload.tsstudio-ui/ui/app/src/components/FormsEngine/dataSources/modules/videoWebDAVRepo.tsstudio-ui/ui/app/src/components/FormsEngine/dataSources/modules/videoWebDAVUpload.tsstudio-ui/ui/app/src/components/FormsEngine/dataSources/modules/webDavRepo.tsstudio-ui/ui/app/src/components/FormsEngine/dataSources/modules/webDavUpload.tsstudio-ui/ui/app/src/components/FormsEngine/dataSources/services.tsstudio-ui/ui/app/src/components/FormsEngine/dataSources/types.tsstudio-ui/ui/app/src/components/FormsEngine/lib/controlHelpers.tsxstudio-ui/ui/app/src/env/studioUI.ts
💤 Files with no reviewable changes (1)
- studio-ui/ui/app/src/components/FormsEngine/dataSources/modules/remoteStubs.ts
Contributor
Author
|
@coderabbitai can you check if everything looks good? Please give it a final review before I hand over for human review |
|
✅ Action performedFull review finished. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
#7418
Summary by CodeRabbit
New Features
Documentation