Upgrade windows docker images base to Ubuntu 24.04#1755
Upgrade windows docker images base to Ubuntu 24.04#1755Raniz85 wants to merge 1 commit intocross-rs:mainfrom
Conversation
|
/ci try --target *indows-gnu |
This comment has been minimized.
This comment has been minimized.
Try run for comment
Failed Jobs
|
|
have a look at #1580 also, where we've been trying to bump the image |
Newer versions of Rust require a newer version of MingW. Fixes cross-rs#1754, cross-rs#1737
82b57ad to
38d5272
Compare
|
This turned out to be quite the rabbit hole. Made deeper because I haven't worked with C++ for some 20 years :S I've spent considerable time trying to figure out what goes wrong - with a lot of help from pushing Claude in various directions. The issue seems to be that the rust-cmake-hello-world crate is incompatible with newer GCC. The solution is to either force libstdc++ to be linked statically (I don't like this solution) or to upgrade RE2 (newer versions doesn't seem to use Either way, the fix needs to be done in https://github.com/cross-rs/rust-cmake-hello-world. I think that upgrading RE2 is the better option, but that will break the test for most (all?) other images right now since they don't support C++17, which Abseil (a dependency of RE2 since ~May 2024) requires - it could help the effort in #1850 though since 24.04 has toolchains that support C++17. There's a PR open on rust-cmake-hello-world to upgrade RE2, once that is merged, the CI run should pass for these images again (though it will break for pretty much all the other images that use GCC-8 or older). One option would be to point test.sh to specific revisions of rust-cmake-hello-world instead of main until all images have been updated. |
|
Two questions:
|
|
I think using different refs makes sense, I switched the PR to be put on branch |
|
We can combine the prs, but we can also just rebase the other one on top of it :) small incremental changes are nice though also |
|
I agree :) I'll update the test script to use the new ref and then we can retry the image tests |
Newer versions of Rust require a newer version of MingW.
Fixes #1754, #1737