Problem: missing ADR for precompiled#1191
Draft
thomas-nguy wants to merge 4 commits intocrypto-org-chain:mainfrom
Draft
Problem: missing ADR for precompiled#1191thomas-nguy wants to merge 4 commits intocrypto-org-chain:mainfrom
thomas-nguy wants to merge 4 commits intocrypto-org-chain:mainfrom
Conversation
5cc829e to
0dadeb8
Compare
a4e2523 to
9d26c3a
Compare
thomas-nguy
commented
Oct 2, 2023
|
|
||
| ```go | ||
|
|
||
| const ( |
Collaborator
Author
There was a problem hiding this comment.
@mmsqe Not sure why we are using a prefix based encoding rather than abi encoding like for all the other precompiled?
40c222b to
4be4a5c
Compare
4be4a5c to
29b27e3
Compare
d8ffbaa to
47daa4e
Compare
Codecov Report✅ All modified and coverable lines are covered by tests.
Additional details and impacted files@@ Coverage Diff @@
## main #1191 +/- ##
===========================================
- Coverage 36.97% 16.73% -20.24%
===========================================
Files 115 79 -36
Lines 10235 5766 -4469
===========================================
- Hits 3784 965 -2819
+ Misses 6078 4723 -1355
+ Partials 373 78 -295 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
👮🏻👮🏻👮🏻 !!!! REFERENCE THE PROBLEM YOUR ARE SOLVING IN THE PR TITLE AND DESCRIBE YOUR SOLUTION HERE !!!! DO NOT FORGET !!!! 👮🏻👮🏻👮🏻
Draft for ADR-010
PR Checklist:
make)make test)go fmt)golangci-lint run)go list -json -m all | nancy sleuth)Thank you for your code, it's appreciated! :)