Log Range as string representation rather than array#223
Merged
bcardiff merged 1 commit intocrystal-lang:masterfrom Nov 19, 2025
Merged
Log Range as string representation rather than array#223bcardiff merged 1 commit intocrystal-lang:masterfrom
bcardiff merged 1 commit intocrystal-lang:masterfrom
Conversation
straight-shoota
approved these changes
Nov 14, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Discovered while implementing support for PostgreSQL ranges in will/crystal-pg#304.
I encountered an issue where
Rangearguments containingTimeobjects would cause logging failures:The existing
MetadataValueConverter.arg_to_log(arg : Enumerable)method attempts to convert ranges to an array, which fails forTimeranges.