Skip to content

Return storageprovider id in space root info #4000

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
butonic wants to merge 1 commit into
base: edge
Choose a base branch
from
Open

Return storageprovider id in space root info #4000

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions changelog/unreleased/fix-propfind-root-id.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,5 @@
Bugfix: Fix propfind root id

decomposedfs now returns the storageprovider id in the root info when listing spaces

https://github.com/cs3org/reva/pull/4000
3 changes: 3 additions & 0 deletions internal/grpc/services/storageprovider/storageprovider.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -545,6 +545,7 @@ func (s *Service) CreateStorageSpace(ctx context.Context, req *provider.CreateSt
}

s.addMissingStorageProviderID(resp.GetStorageSpace().GetRoot(), resp.GetStorageSpace().GetId())
s.addMissingStorageProviderID(resp.GetStorageSpace().GetRootInfo().GetId(), nil)
return resp, nil
}

Expand Down Expand Up @@ -589,6 +590,7 @@ func (s *Service) ListStorageSpaces(ctx context.Context, req *provider.ListStora
}

s.addMissingStorageProviderID(sp.GetRoot(), sp.GetId())
s.addMissingStorageProviderID(sp.GetRootInfo().GetId(), nil)
}

return &provider.ListStorageSpacesResponse{
Expand All @@ -608,6 +610,7 @@ func (s *Service) UpdateStorageSpace(ctx context.Context, req *provider.UpdateSt
return nil, err
}
s.addMissingStorageProviderID(res.GetStorageSpace().GetRoot(), res.GetStorageSpace().GetId())
s.addMissingStorageProviderID(res.GetStorageSpace().GetRootInfo().GetId(), nil)
return res, nil
}

Expand Down