merge dev into toast branch#200
Open
h0ethan04 wants to merge 1 commit intoteacher-end-toaster-cleanupfrom
Open
merge dev into toast branch#200h0ethan04 wants to merge 1 commit intoteacher-end-toaster-cleanupfrom
h0ethan04 wants to merge 1 commit intoteacher-end-toaster-cleanupfrom
Conversation
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR merges changes from the dev branch into the toast branch and updates a wide range of components and configuration files. Key changes include UI and styling adjustments in multiple modals and view components, refactoring and cleanup in teacher-related components, and modifications to routing and workflow configuration.
Reviewed Changes
Copilot reviewed 141 out of 141 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
| client/src/components/bookings/teacherView/qrcode/ClassCheckInHandler.jsx | Reordered imports and slightly reformatted localStorage usage. |
| client/src/components/bookings/teacherView/qrcode/CheckInHandler.jsx | Removed obsolete console logs and commented code. |
| client/src/components/bookings/teacherView/TeacherEventViewModal.jsx | Updated modal layout and added support for tags and new positioning props. |
| client/src/components/bookings/TeacherEditModal.jsx | Refactored tag handling and instructor data fetching; improved asynchronous deletion logic. |
| Other files (e.g., TeacherViewModal.jsx, ProtectedRoute.tsx, CatchAll.tsx, Workflows) | Minor UI tweaks, routing changes, import reordering, and CI workflow branch updates. |
Comments suppressed due to low confidence (2)
client/src/components/bookings/TeacherEditModal.jsx:210
- Consider using Promise.all to await all asynchronous deletion calls when removing class tags. This change will ensure that all deletion operations complete (or fail) before proceeding, improving error handling and synchronization.
tags.map(async (tag) => { await backend.delete(`/class-tags/${classData.id}/${tag.id}`).catch((err) => { console.error(err); }); });
.github/workflows/run-checks.yml:28
- Reconsider removing the '--frozen-lockfile' flag from the dependency installation command. Retaining it can help ensure reproducible builds by strictly enforcing resolved dependency versions.
node_modules && yarn install
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Screenshots/Media
Issues
Closes #