Conversation
|
CI is green, and I tested the generated APK on a real Android device. The new scripting functions were individually confirmed:
During end-to-end overlay testing, I encountered device/browser-specific Accessibility and overlay instability. Curbox’s existing Instagram UI reducers also did not work reliably on this device, so I could not establish a reliable end-to-end card-filtering result. This appears separate from the new interpreter functions, but I want to report the limitation transparently. The PR is ready for maintainer review, especially regarding the implementation and automated tests. |
|
Update/correction to my previous testing note: After further testing, I realized that Curbox’s existing Instagram and YouTube UI Hider features do work on my device. My earlier conclusion was premature and was likely caused by my testing setup or configuration rather than Curbox itself. Because of this, I would like to continue testing the proposed I apologize for the confusion in my earlier comment. Please continue to consider this pull request. I am happy for it to be reviewed primarily on the implementation, execution-budget safety, caching, and automated tests while I continue investigating the end-to-end custom script behavior. |
|
sure, it looks fine to me. i'll merge it in a while. the instagram blocker stuff is very experimental and doesnt seem to work if you use instagram in any other language except english |
|
Thank you for your contribution :) |
|
Thank you for building the app and letting me contribute :) |
Summary
This pull request adds contextual text-matching capabilities to UI Hider scripts.
It implements:
Added scripting functions
Motivation
Some UI cards expose their title, description, source, and exception context through separate Accessibility nodes.
For example:
Matching only the title node can create a false positive. Bounded subtree-text collection allows scripts to evaluate the candidate card as a whole before deciding whether to hide it.
This also enables generic contextual rules such as:
The implementation is generic and does not contain TemizWeb-specific or PMO-specific rules.
Safety and performance
ConcurrentHashMap.Tests
Tests were added for:
Closes #355