Skip to content

feat: add time unit selector for warning proceed time window - #362

Merged
nethical6 merged 3 commits into
curbox-app:kt-rewritefrom
binayshaw7777:issue/330
Jul 20, 2026
Merged

nethical6 merged 3 commits into
curbox-app:kt-rewritefrom
binayshaw7777:issue/330

Conversation

@binayshaw7777

@binayshaw7777 binayshaw7777 commented Jul 19, 2026

Copy link
Copy Markdown
Contributor

Summary

  • Warning config's "proceed time window" slider previously only worked in minutes (max 240 min). Users couldn't express durations longer than a few hours.
  • Added a unit selector text button with trailing chevron icon (Minutes / Hours / Days) next to the slider. Slider bounds adjust per unit: 1–60 min, 1–24 hr, 1–30 days.
  • Existing stored values (in minutes) auto-detect the best unit on load (days → hours → minutes). Saved value is always converted back to minutes, so proceedsTimeWindowMn storage format is unchanged.
  • Updated warning_time_window string format to include the unit label; all 7 translation files updated.

Resolves #330

Screenshots

image image

Test plan

  • Open warning config for any blocker. Confirm time window shows correct unit for existing saved value
  • Switch unit dropdown — verify slider bounds change and title updates
  • Save and reopen — confirm value round-trips correctly (e.g. 2 hours saves as 120 mins, reloads as "2 Hours")
  • Test edge: value at max of one unit, switch to another unit — slider should clamp to new bounds
  • Verify all 7 locales compile without missing string errors

@binayshaw7777 binayshaw7777 changed the title add unit selection for proceed time window in warning configuration [DO NOT MERGE] feat: add time unit selector for warning proceed time window Jul 19, 2026
@binayshaw7777 binayshaw7777 changed the title feat: add time unit selector for warning proceed time window feat: add time unit selector for warning proceed time window [DO NOT MERGE] Jul 19, 2026
@binayshaw7777 binayshaw7777 changed the title feat: add time unit selector for warning proceed time window [DO NOT MERGE] feat: add time unit selector for warning proceed time window Jul 20, 2026
@binayshaw7777

Copy link
Copy Markdown
Contributor Author

Can you please review @nethical6 ?

@nethical6
nethical6 merged commit 86aa352 into curbox-app:kt-rewrite Jul 20, 2026
1 check passed
@nethical6

Copy link
Copy Markdown
Member

thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[Feature]: Increase "Time window" for "Limit unlock frequency"

2 participants