Conversation
- Change message field from String to List<String> - Update display and editor to pick a random message - Adjust comparator logic for list comparison - No UI support, just hardcoded list
* changed default message * text to show the user that random message are possible was altered. * in config it now dysplasia each random message divided by ", " Note: i am terrible with UI so feel free to change this to whatever you want
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I have added functionality that makes random messages possible:
"Message 1", "Message 2"Note: i am terrible with UI i just want somebody to add an little text (or something idk) that would indicate to the user that he can use ", " to make the app chose a random message every time a warning pops up. Thanks for understanding.
One last questions:
WHy are comments prohibited?
"Only use comments when absolutely necessary or for documenting complex logic."
I have spent more than 3 hours just trying to understand this codebase in the first place. it took more work just to search and find all of the functions to patch than actually coding. For people like me (first time seeing this codebase) it would be more than ideal to include some amount of comments to explain what each class does and so on...
Thank you for the time. :)