Skip to content

In MusicXML, a clef with no number is for staff 1, not for all staves in a part #1905

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
mscuthbert merged 5 commits into from
Jun 16, 2026
+166 −78
Merged

In MusicXML, a clef with no number is for staff 1, not for all staves in a part #1905

Changes from 3 commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
a0df6a4
In MusicXML, a clef with no number is for staff 1, not for all staves…
gregchapman-dev May 31, 2026
295864a
Fix doctest (0: is the default, 1: is the clef being tested).
gregchapman-dev May 31, 2026
d8a2f4d
Slightly improved doctest.
gregchapman-dev May 31, 2026
41cba10
Fix and test Rests, simplify some code
mscuthbert Jun 16, 2026
f9028c5
redefined name
mscuthbert Jun 16, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
13 changes: 11 additions & 2 deletions music21/musicxml/xmlToM21.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2556,6 +2556,11 @@ def getStaffNumber(mxObjectOrNumber) -> int:
pass
except AttributeError: # a normal number
pass
if mxObject.tag in ('staff-layout',
'staff-details',
'clef'):
# for this subset of number'ed tags, no number means staff 1
return 1
return NO_STAFF_ASSIGNED
else:
return NO_STAFF_ASSIGNED
Expand Down Expand Up @@ -6011,13 +6016,17 @@ def handleClef(self, mxClef):

>>> MP = musicxml.xmlToM21.MeasureParser()
>>> MP.handleClef(mxClef)
>>> MP.lastClefs
{0: <music21.clef.TrebleClef>}
>>> MP.lastClefs[1]
<music21.clef.TrebleClef>
>>> MP.lastClefs[0]
<music21.clef.TrebleClef>

@mscuthbert mscuthbert Jun 15, 2026

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this test was insufficient before and it's insufficient now too -- since we have no tests of what this did before. I'll make a push onto this.


>>> mxClefBC = ET.fromstring('<clef number="2"><sign>F</sign><line>4</line></clef>')
>>> MP.handleClef(mxClefBC)
>>> MP.lastClefs[2]
<music21.clef.BassClef>
>>> MP.lastClefs[1]
<music21.clef.TrebleClef>
>>> MP.lastClefs[0]
<music21.clef.TrebleClef>
'''
Expand Down
Loading