Conversation
amritagos
left a comment
amritagos
left a comment
There was a problem hiding this comment.
Please address the comments and update the PR.
Thanks for this!
| set(CMAKE_CXX_FLAGS "-g -O0 -fprofile-arcs -ftest-coverage") | ||
| set(CMAKE_C_FLAGS "-g -O0 -fprofile-arcs -ftest-coverage") |
There was a problem hiding this comment.
Perhaps this should be only set for the Debug builds?
nix/nixpkgs/default.src.json
Outdated
| "rev": "ae002fe44e96b868c62581e8066d559ca2179e01", | ||
| "sha256": "1bawyz3ksw2sihv6vsgbvhdm4kn63xrrj5bavg6mz5mxml9rji89" | ||
| "rev": "8130f3c1c2bb0e533b5e150c39911d6e61dcecc2", | ||
| "sha256": "154nrhmm3dk5kmga2w5f7a2l6j79dvizrg4wzbrcwlbvdvapdgkb" |
There was a problem hiding this comment.
This is a breaking change and should be documented a bit more.
There was a problem hiding this comment.
Good idea, I'll update the PR description. Though the changes shouldn't affect general users much. A good practice is running nix-collect-garbage whenever the nix versions are updated.
Co-Authored-By: Amrita Goswami <32496815+amritagos@users.noreply.github.com>
Codecov Report
@@ Coverage Diff @@
## master #2 +/- ##
=========================================
Coverage ? 60.86%
=========================================
Files ? 7
Lines ? 920
Branches ? 0
=========================================
Hits ? 560
Misses ? 360
Partials ? 0Continue to review full report at Codecov.
|
This reverts commit 767af1e.
HaoZeke
force-pushed
the
master
branch
2 times, most recently
from
d9d9add to
fd1651f
Compare
HaoZeke
force-pushed
the
main
branch
8 times, most recently
from
8239a8b to
3665a68
Compare
|
2 participants
Initialize coverage metrics and also update the CI to run all branches.