Open
Conversation
HaoZeke
approved these changes
Jul 17, 2023
Comment on lines
690
to
+689
| << "Fatal Error: The file does not exist or you gave the wrong path.\n"; | ||
| // Throw exception? | ||
| return *yCloud; | ||
| return yCloud; |
Member
There was a problem hiding this comment.
This should actually throw. Not for this PR though :)
HaoZeke
requested changes
Jul 17, 2023
Member
HaoZeke
left a comment
HaoZeke
left a comment
There was a problem hiding this comment.
The test failures might be because the lua bindings need some work.
RuhiRG
force-pushed
the
fixup
branch
2 times, most recently
from
0693ba0 to
4c7f9f8
Compare
HaoZeke
changed the title
Co-authored-by: Rohit Goswami <rog32@hi.is>
Since it seems to break on musllinux... https://github.com/d-SEAMS/PydSEAMSlib/actions/runs/10565220956/job/29269283061?pr=21#step:4:1135 In file included from ../subprojects/seams-core/src/backward.cpp:40: ../subprojects/seams-core/src/include/external/backward.hpp:261:10: fatal error: execinfo.h: No such file or directory 261 | #include <execinfo.h> | ^~~~~~~~~~~~
This reverts commit fc84473.
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In keeping with #36. Originally this PR was meant to only change the function return types. However, as noted below, this breaks the CI.
So it was later further expanded to completely remove the
luabindings, since they are incompatible with the new by value return policies of the functions.Closes #35 as well.