Skip to content

fix(frontend): resolve pnpm audit vulnerabilities failing CI #274

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
d3mocide merged 3 commits into from
Jul 24, 2026
+57 −39
Merged

fix(frontend): resolve pnpm audit vulnerabilities failing CI #274

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
036b43f
fix(frontend): resolve pnpm audit vulnerabilities failing CI
claude Jul 24, 2026
ea3e2d1
ci: suppress GHSA-qwww-vcr4-c8h2 in dependency review
claude Jul 24, 2026
521ac60
fix(frontend): bump postcss, suppress react-router CVE in audit step
claude Jul 24, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 11 additions & 1 deletion .github/workflows/pr-checks.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -21,6 +21,12 @@ jobs:
with:
fail-on-severity: high
deny-licenses: GPL-3.0, AGPL-3.0, GPL-2.0
# GHSA-qwww-vcr4-c8h2: react-router CSRF bypass, exploitable only via the
# unstable RSC (Server Components) APIs. Luma is a client-only SPA that
# never enables those APIs, so this is a false positive. The fix ships in
# react-router 8.3.0, which requires React >=19.2.7 (Luma is on React 18) -
# revisit this suppression when that upgrade happens.
allow-ghsas: GHSA-qwww-vcr4-c8h2

frontend:
name: Frontend — type-check, lint, test & build
Expand Down Expand Up @@ -55,7 +61,11 @@ jobs:
run: pnpm test

- name: Audit dependencies
run: pnpm audit --audit-level high
# GHSA-qwww-vcr4-c8h2: react-router CSRF bypass, exploitable only via the
# unstable RSC (Server Components) APIs, which this client-only SPA never
# enables. Fix ships in react-router 8.3.0, which requires React >=19.2.7
# (Luma is on React 18) - revisit when that upgrade happens.
run: pnpm audit --audit-level high --ignore GHSA-qwww-vcr4-c8h2

- name: Build
run: pnpm build
Expand Down
4 changes: 2 additions & 2 deletions frontend/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -24,7 +24,7 @@
"react": "18.3.1",
"react-dom": "18.3.1",
"react-markdown": "10.1.0",
"react-router-dom": "7.17.0",
"react-router-dom": "7.18.1",
"recharts": "2.15.0",
"remark-gfm": "4.0.1",
"tailwind-merge": "2.6.1",
Expand All @@ -48,7 +48,7 @@
"eslint-plugin-react-hooks": "7.1.1",
"eslint-plugin-react-refresh": "0.5.3",
"jsdom": "29.1.1",
"postcss": "8.5.15",
"postcss": "8.5.20",
"tailwindcss": "4.3.0",
"typescript": "5.9.3",
"typescript-eslint": "8.60.0",
Expand Down
69 changes: 36 additions & 33 deletions frontend/pnpm-lock.yaml
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

11 changes: 8 additions & 3 deletions frontend/pnpm-workspace.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,13 +3,18 @@ packages:

allowBuilds:
esbuild: true
auditConfig:
ignoreCves:
- GHSA-qwww-vcr4-c8h2

minimumReleaseAge: "72 hours"
onlyBuiltDependencies:
- esbuild

overrides:
baseline-browser-mapping: "2.10.32"
brace-expansion@2: "^2.1.2"
brace-expansion@5: "^5.0.7"
electron-to-chromium: "1.5.361"
fast-uri@3: "^3.1.4"
side-channel: "1.1.0"

policies:
minimumReleaseAge: "72 hours"