refactor(stackflow): scope swipe-back DOM writes to individual elements#1359
refactor(stackflow): scope swipe-back DOM writes to individual elements#1359manNomi wants to merge 1 commit intodaangn:fix/scope-swipe-back-varsfrom
Conversation
Replace CSS variable cascade on stack root with direct inline style manipulation on specific elements (topLayer, dim, behindLayer, appBar). This avoids full subtree style recalculation on iOS WebKit which was resetting scroll positions on the behind activity during swipe-back. - Group 6 individual DOM refs into single SwipeElements ref object - Extract INITIAL_SWIPE_CONTEXT constant and computeDisplacement helper - Unify swiped/canceling branches in endSwipeBack via finalTarget - Keep CSS vars only on appBar for appBar-specific styling Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
|
|
Important Review skippedAuto reviews are disabled on base/target branches other than the default branch. Please check the settings in the CodeRabbit UI or the ⚙️ Run configurationConfiguration used: Path: .coderabbit.yaml Review profile: CHILL Plan: Pro Run ID: You can disable this status message by setting the Use the checkbox below for a quick retry:
✨ Finishing Touches🧪 Generate unit tests (beta)
📝 Coding Plan
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment Tip You can make CodeRabbit's review stricter and more nitpicky using the `assertive` profile, if that's what you prefer.Change the |
|
/snapshot |
📦 Snapshot Release
|
|
will resolve in #1444 |
안녕하세요!
앱스크린 마이그레이션 작업에서 성능개선을 위해찾아왔어요
stack 루트에 CSS 변수를 설정하는 방식 대신,
개별 요소(topLayer, dim, behindLayer, appBar)에 inline style을 직접 조작하도록 변경했어요!