feat(css): increase iOS font scaling limit from 135% to 160%#1424
Draft
junghyeonsu wants to merge 3 commits intodevfrom
Draft
feat(css): increase iOS font scaling limit from 135% to 160%#1424junghyeonsu wants to merge 3 commits intodevfrom
junghyeonsu wants to merge 3 commits intodevfrom
Conversation
Raise the iOS platform-specific --seed-font-size-limit-max and --seed-line-height-limit-max from 1.35 to 1.6 to allow larger dynamic type sizes on iOS devices. Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
🦋 Changeset detectedLatest commit: 59bc60d The changes in this PR will be included in the next version bump. This PR includes changesets to release 3 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
Contributor
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Path: .coderabbit.yaml Review profile: CHILL Plan: Pro Run ID: 📒 Files selected for processing (1)
✅ Files skipped from review due to trivial changes (1)
📝 WalkthroughWalkthroughiOS 전용 CSS 변수 두 개( Changes
Estimated code review effort🎯 1 (Trivial) | ⏱️ ~3 minutes Poem
🚥 Pre-merge checks | ✅ 3✅ Passed checks (3 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Contributor
Alpha Preview (Stackflow SPA)
|
Contributor
Alpha Preview (Storybook)
|
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
Caution
Some comments are outside the diff and can’t be posted inline due to platform limitations.
⚠️ Outside diff range comments (1)
packages/qvism-preset/src/global.ts (1)
34-44:⚠️ Potential issue | 🟡 Minor주석 내용을 새로운 한계값에 맞게 업데이트해야 합니다.
Line 39의 주석이 여전히 "max 135%"를 참조하고 있지만, 이제 iOS에서는 160%로 제한됩니다. 코드 변경 사항과 일치하도록 주석을 업데이트해 주세요.
📝 주석 수정 제안
/** * 0.9412 is the font size multiplier for iOS * It converts iOS default 17px to web standard 16px - * Individual font sizes are clamped to max 135% in the token system + * Individual font sizes are clamped to max 160% in the token system */🤖 Prompt for AI Agents
Verify each finding against the current code and only fix it if needed. In `@packages/qvism-preset/src/global.ts` around lines 34 - 44, 주석이 iOS 폰트 크기 제한을 "max 135%"로 여전히 언급하고 있어 실제 코드 변경(새 한계 160%)과 불일치합니다; html[data-seed-platform='ios'][data-seed-font-scaling='enabled'] 블록 내 주석(위치: 설명 블록 바로 위 또는 옆의 "--seed-font-size-multiplier" 설명)을 수정하여 "Individual font sizes are clamped to max 160% in the token system" 또는 동등한 문구로 업데이트해 주세요.
🤖 Prompt for all review comments with AI agents
Verify each finding against the current code and only fix it if needed.
Outside diff comments:
In `@packages/qvism-preset/src/global.ts`:
- Around line 34-44: 주석이 iOS 폰트 크기 제한을 "max 135%"로 여전히 언급하고 있어 실제 코드 변경(새 한계
160%)과 불일치합니다; html[data-seed-platform='ios'][data-seed-font-scaling='enabled']
블록 내 주석(위치: 설명 블록 바로 위 또는 옆의 "--seed-font-size-multiplier" 설명)을 수정하여 "Individual
font sizes are clamped to max 160% in the token system" 또는 동등한 문구로 업데이트해 주세요.
ℹ️ Review info
⚙️ Run configuration
Configuration used: Path: .coderabbit.yaml
Review profile: CHILL
Plan: Pro
Run ID: 9c8d0aa3-0647-49b9-be6a-f2269aadc623
⛔ Files ignored due to path filters (8)
packages/css/all.cssis excluded by!packages/css/**/*packages/css/all.layered.cssis excluded by!packages/css/**/*packages/css/all.layered.min.cssis excluded by!packages/css/**/*packages/css/all.min.cssis excluded by!packages/css/**/*packages/css/base.cssis excluded by!packages/css/**/*packages/css/base.layered.cssis excluded by!packages/css/**/*packages/css/base.layered.min.cssis excluded by!packages/css/**/*packages/css/base.min.cssis excluded by!packages/css/**/*
📒 Files selected for processing (1)
packages/qvism-preset/src/global.ts
Contributor
Alpha Preview (Docs)
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
--seed-font-size-limit-max,--seed-line-height-limit-max)을 1.35에서 1.6으로 확대bun generate:all로 CSS 생성물 업데이트 완료Test plan
bun generate:all실행 후base.css에서 iOS limit 1.6 반영 확인bun test:all통과 (기존 무관 테스트 1건 제외 588 pass)🤖 Generated with Claude Code
Summary by CodeRabbit
릴리스 노트