Skip to content

feat(popover): add hover trigger mode#1478

Open
te6-in wants to merge 4 commits intoalphafrom
feat/popover-hover
Open

feat(popover): add hover trigger mode#1478
te6-in wants to merge 4 commits intoalphafrom
feat/popover-hover

Conversation

@te6-in
Copy link
Copy Markdown
Member

@te6-in te6-in commented Apr 20, 2026

No description provided.

te6-in and others added 2 commits April 20, 2026 16:40
@te6-in @claude
feat(popover): add hover trigger mode
7886f85 
Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
@te6-in @claude
docs(help-bubble): add hover trigger example
6940647 
Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
@coderabbitai
Copy link
Copy Markdown
Contributor

coderabbitai Bot commented Apr 20, 2026 •
edited
Loading

Important

Review skipped

Auto reviews are disabled on base/target branches other than the default branch.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Pro

Run ID: 0955e794-796a-4de1-ab4b-2983976be53a

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

  • 🔍 Trigger review
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch feat/popover-hover

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@changeset-bot
Copy link
Copy Markdown

changeset-bot Bot commented Apr 20, 2026 •
edited
Loading

⚠️ No Changeset found

Latest commit: c16aa55

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@github-actions
Copy link
Copy Markdown
Contributor

github-actions Bot commented Apr 20, 2026

Alpha Preview (Stackflow SPA)

@github-actions
Copy link
Copy Markdown
Contributor

github-actions Bot commented Apr 20, 2026

Alpha Preview (Storybook)

@github-actions
Copy link
Copy Markdown
Contributor

github-actions Bot commented Apr 20, 2026

Alpha Preview (Docs)

te6-in and others added 2 commits April 20, 2026 20:52
@te6-in @claude
fix(popover): derive trigger aria from role, default to tooltip on hover
ffff897 
Hardcoded aria-haspopup="dialog" and aria-expanded on the trigger
propagated dialog semantics even when trigger="hover" was used as a
tooltip. Let useRole emit the correct aria set based on role, default
the role to "tooltip" when trigger is "hover" and expose role as a
prop for explicit override.

Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
@te6-in @claude
refactor(popover): decouple role default from trigger mode
c16aa55 
Keep the default role as "dialog" regardless of trigger mode to preserve
existing HelpBubble behavior. Revisit the default (likely "tooltip" for
HelpBubble based on usage patterns) in a separate issue. The role prop
stays exposed for explicit override.

Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

@te6-in te6-in

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

1 participant

@te6-in