fix(lynx-react): move lynx-ui-sheet to dependency#1506
fix(lynx-react): move lynx-ui-sheet to dependency#1506junghyeonsu wants to merge 2 commits intolynxfrom
Conversation
|
Important Review skippedDraft detected. Please check the settings in the CodeRabbit UI or the ⚙️ Run configurationConfiguration used: Path: .coderabbit.yaml Review profile: CHILL Plan: Pro Run ID: You can disable this status message by setting the Use the checkbox below for a quick retry:
✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
🦋 Changeset detectedLatest commit: 5844b2a The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
Summary
@lynx-js/lynx-ui-sheetfrompeerDependenciestodependenciesin@seed-design/lynx-reactWhy
BottomSheetin@seed-design/lynx-reactdirectly wraps and depends on@lynx-js/lynx-ui-sheetat runtime. Treating it as a peer created extra install friction and required registry-specific compensation to make manual installation and CLI flows work correctly.Making it a direct dependency keeps the package contract aligned with the runtime implementation and removes the need for special-case install metadata.
Impact
@lynx-js/lynx-ui-sheetseparately when using LynxBottomSheetbottom-sheetgo back to installing@seed-design/lynx-reactBottomSheetRootReffrom@seed-design/lynx-reactValidation
bun generate:allbun test packages/cli/src/tests/resolve-dependencies.test.tsbun test:all(fails due to an existing unrelated issue inexamples/lynx-spa/src/__tests__/index.test.tsx: missingreact/jsx-dev-runtime)bun lynx-react:test(fails due to an existing environment/dependency issue: missingpreactvia@hongzhiyuan/preact/compat)