Skip to content

fix(lynx-react): move lynx-ui-sheet to dependency#1506

Draft
junghyeonsu wants to merge 2 commits intolynxfrom
codex/lynx-bottom-sheet-dependency
Draft

fix(lynx-react): move lynx-ui-sheet to dependency#1506
junghyeonsu wants to merge 2 commits intolynxfrom
codex/lynx-bottom-sheet-dependency

Conversation

@junghyeonsu
Copy link
Copy Markdown
Contributor

Summary

  • move @lynx-js/lynx-ui-sheet from peerDependencies to dependencies in @seed-design/lynx-react
  • remove the BottomSheet-specific registry/CLI install workaround and keep the generated Lynx registry metadata simple again
  • update Lynx BottomSheet docs and internal wrap guidance to match the new dependency model

Why

BottomSheet in @seed-design/lynx-react directly wraps and depends on @lynx-js/lynx-ui-sheet at runtime. Treating it as a peer created extra install friction and required registry-specific compensation to make manual installation and CLI flows work correctly.

Making it a direct dependency keeps the package contract aligned with the runtime implementation and removes the need for special-case install metadata.

Impact

  • consumers no longer need to install @lynx-js/lynx-ui-sheet separately when using Lynx BottomSheet
  • generated registry install instructions for Lynx bottom-sheet go back to installing @seed-design/lynx-react
  • the imperative ref example now uses BottomSheetRootRef from @seed-design/lynx-react

Validation

  • bun generate:all
  • bun test packages/cli/src/tests/resolve-dependencies.test.ts
  • bun test:all (fails due to an existing unrelated issue in examples/lynx-spa/src/__tests__/index.test.tsx: missing react/jsx-dev-runtime)
  • bun lynx-react:test (fails due to an existing environment/dependency issue: missing preact via @hongzhiyuan/preact/compat)

@coderabbitai
Copy link
Copy Markdown
Contributor

coderabbitai Bot commented Apr 22, 2026

Important

Review skipped

Draft detected.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Pro

Run ID: e424d376-8e3f-497f-a566-864615297cf4

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

  • 🔍 Trigger review
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch codex/lynx-bottom-sheet-dependency

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@changeset-bot
Copy link
Copy Markdown

changeset-bot Bot commented Apr 22, 2026

🦋 Changeset detected

Latest commit: 5844b2a

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
@seed-design/lynx-react Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant