Add switch and restore completion to v0#737
Closed
theaquamarine wants to merge 4 commits intodahlbyk:v0from
Closed
Add switch and restore completion to v0#737theaquamarine wants to merge 4 commits intodahlbyk:v0from
theaquamarine wants to merge 4 commits intodahlbyk:v0from
Conversation
dahlbyk
requested changes
Mar 14, 2020
Owner
dahlbyk
left a comment
dahlbyk
left a comment
There was a problem hiding this comment.
It's not immediately obvious to me why the remaining tests are failing. 🤔
| $paramValues = $gitParamValues[$cmd][$param] | ||
|
|
||
| $completions = if ($paramValues -is [scriptblock]) { | ||
| & $paramValues $filter | Where-Object { $_ -like "$filter*" } |
Collaborator
|
@theaquamarine Given that beta4 is out now with support for these two new git commands, can we close this? Or if you'd like to get this merged, could you apply the fixes from #743 and see if that gets the tests to pass? Thanks. |
Collaborator
|
I'd like to close this now that v1 has shipped. Any objections? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
As discussed in #733 (comment), this would allow v0 to support "new" usage for git at least until v1 updates/releases.
Uses the code from #702 for
restoreandswitchsupport, plus a couple of lines fromGet-GitDirectoryTests.ps1to fix some tests being broken by git asking for user details.