Fix Tests

[dahlbyk]

Following on from #878, trying to get back to all green.

• Correctly reverts the Window Title back to original state is unreliable; might just skip
• Expected: 'igf ' But was: 'git checkout ' seems to be a change in how either Pester or PowerShell handles -Scope Script; changing to -Scope Global seems to fix. (@dscho you were close!)
• Tab completes add file in working dir with special char as quoted suggests core.quotepath=false (from b689b5e in Fix tab expansion for non-ASCII file paths #403) no longer affects git status -sb as expected - a path with special characters is coming back in "" regardless. This feels like a regression, but I haven't gone looking for release notes.

[dahlbyk]

• a path with special characters is coming back in "" regardless

Turns out it's only spaces? git/git@f3fc4a1

[dahlbyk]

• a path with special characters is coming back in "" regardless

Turns out it's only spaces? git/git@f3fc4a1

I'm genuinely confused how this test ever passed. git/git@dbfdc62 is from 2010. 🤔

[rkeithhill]

Why not?

$originalTitle = & $module { $OriginalWindowTitle }

[rkeithhill]

But do it after importing posh-git

[rkeithhill]

Ah, now I see you're capturing this variable in the test fixture before the test runs.

[dahlbyk]

Why not?

$originalTitle = & $module { $OriginalWindowTitle }

I don't use this syntax often, so I refer to

posh-git/src/Utils.ps1

Line 7 in 5a87e8a

# PS> & $m Get-Variable invokeErrors -ValueOnly

[rkeithhill]

Just a few suggestions otherwise LGTM

[rkeithhill]

But do it after importing posh-git

[rkeithhill]

What's with the unrecognized chars? Is that part of the "special char" test? Might be worth adding as another test for emoji/unprintable chars or whatever that is. IIRC this test was meant to check for tab completion with PowerShell and/or regex special chars/syntax e.g. {} and () in the completed text.

[dahlbyk]

Was just being lazy, but yeah the emoji is to ensure we're setting core.quotePath (and it's working as expected). Will break out as a separate test.

[dahlbyk]

What's with the unrecognized chars? Is that part of the "special char" test? Might be worth adding as another test for emoji/unprintable chars or whatever that is. IIRC this test was meant to check for tab completion with PowerShell and/or regex special chars/syntax e.g. {} and () in the completed text.

Was just being lazy, but yeah the emoji is to ensure we're setting core.quotePath (and it's working as expected). Will break out as a separate test.

Turns out we already had a (better) test for this:

posh-git/test/TabExpansion.Tests.ps1

Lines 222 to 226 in a62f90c

	It 'Tab completes non-ASCII file name' {
	&$gitbin config core.quotepath true # Problematic (default) config
	$fileName = "posh$([char]8226)git.txt"
	New-Item $fileName -ItemType File

Relocated into the appropriate Context.

[dahlbyk]

Thanks for the review, @rkeithhill

[dahlbyk]

Why not?

$originalTitle = & $module { $OriginalWindowTitle }

I don't use this syntax often, so I refer to

posh-git/src/Utils.ps1

Line 7 in 5a87e8a

# PS> & $m Get-Variable invokeErrors -ValueOnly

[dahlbyk]

What's with the unrecognized chars? Is that part of the "special char" test? Might be worth adding as another test for emoji/unprintable chars or whatever that is. IIRC this test was meant to check for tab completion with PowerShell and/or regex special chars/syntax e.g. {} and () in the completed text.

Was just being lazy, but yeah the emoji is to ensure we're setting core.quotePath (and it's working as expected). Will break out as a separate test.

Turns out we already had a (better) test for this:

posh-git/test/TabExpansion.Tests.ps1

Lines 222 to 226 in a62f90c

	It 'Tab completes non-ASCII file name' {
	&$gitbin config core.quotepath true # Problematic (default) config
	$fileName = "posh$([char]8226)git.txt"
	New-Item $fileName -ItemType File

Relocated into the appropriate Context.