Params validitanion tests#944
Closed
Ra0to wants to merge 6 commits intodahlbyk:masterfrom
Closed
Conversation
Fixed:
Subcommand 'grep' param 'open-file-in-pager' added missing s ->
'open-files-in-pager'.
Subcommand 'log':
- Missing equal signs:
- 'min-parents' -> 'min-parents='
- 'max-parents' -> 'max-parents='
- Missing s in 'remote' param -> 'remotes'
Subcommand 'pull' removed param 'update-head-ok' that doesn't exists.
Contributor
Author
|
Sorry, tests on my machine completes successfully. Going to investigate problem, closing PR for now. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
During work on PR-943 I created tests for params validation. I'm not sure is they necessary or not. I found several problems in current suggestions and fixed them in this PR and linked above too.
It takes more much more time for tests completion.
On my machine:
Feel free to ask any improvements.