Fix issues that break MSVC strict compilation#294
Open
oznogon wants to merge 1 commit intodaid:masterfrom
Open
Fix issues that break MSVC strict compilation#294oznogon wants to merge 1 commit intodaid:masterfrom
oznogon wants to merge 1 commit intodaid:masterfrom
Conversation
oznogon
force-pushed
the
fix-strict-compilation
branch
from
81c6783 to
50b63c6
Compare
oznogon
force-pushed
the
fix-strict-compilation
branch
from
50b63c6 to
859a8ee
Compare
oznogon
force-pushed
the
fix-strict-compilation
branch
from
859a8ee to
2d6746e
Compare
- Add an explicit public default constructor to ComponentStorage to avoid "no appropriate default constructor available" errors - Explicitly define the static inline ComponentStorage member named storage, instead of only declaring it, to avoid "use of undefined type 'sp::ecs::ComponentStorage<...>'" errors - Use _WIN32 instead of WIN32 in preprocessor ifdefs; MSVC 18 doesn't appear to define WIN32. - Explicitly instantiate multiplayerReplicationFunctions templates.
oznogon
force-pushed
the
fix-strict-compilation
branch
from
2d6746e to
660f64c
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The
/permissive-flag that appears in CMakeLists.txt seems to be ignored, discarded, or no-op on MSVC builds. The resulting errors block compilation.ComponentStorageto avoidno appropriate default constructor availableerrorsComponentStoragemember namedstorage, instead of only declaring it, to avoiduse of undefined type 'sp::ecs::ComponentStorage<...>'errors_WIN32instead ofWIN32in preprocessor ifdefs; MSVC 18 doesn't appear to defineWIN32multiplayerReplicationFunctionstemplatesuint32_tThese changes should have no impact on non-MSVC builds, and would contribute toward unblocking MSVC as a compiler.