Make subscriber cleanup race-safe - #121
Merged
Merged
Conversation
Remove server-side waiting by coordinating publication commits with subscriber teardown, preserving slot and split-buffer safety across crashes.
Wait for the complete replicated topology before restarting the server so recovery assertions cannot race pending shadow events.
Ensure publisher cleanup cannot erase delivery bits seeded by a subscriber ID that is concurrently reused.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
sub_owners, and retiring slots that become eligible after the subscriber count changesTest plan
bazelisk test //client:client_test //rust_client:client_test //common:common_test //server:server_test //shadow:shadow_test //c_client:client_testbazelisk test //... --nocache_test_resultsgit diff --check