Return 404 on orphaned assets#2744
Open
jjnesbitt wants to merge 3 commits into
Open
Conversation
* origin/master: (71 commits) Refactor no-author citation handling per-format Make advanced-search help popover responsive (closes #2818) Inline _parse_date into apply_search_filters Update web/src/components/DandisetSearchField.vue Fix "This Version" header style on DLP Address round-2 review feedback species: scan all attributed subjects, not just the first Drop has_ prefix from asset operators Use long-form Celery options in native instructions Fix native Celery command for RabbitMQ 4.3 Address review: strict parser, AI-marked tests, cleanup e2e: match search placeholder by stable substring Drop unused owner parameter from _delete_existing Add Gmail-style advanced search to dandiset listing [gh-actions](deps): Bump actions/add-to-project from 1.0.2 to 2.0.0 Get `fsspec` from `dandi[extras]` Fix incompatibility with RabbitMQ 4.3 Update dependency fsspec to v2026 Update dependency marked to v18 Fix compatability between Allauth rate limiting and Heroku ...
Member
|
merged master to redo CI and see where we stand ATM on this |
Member
Author
|
I believe the blocker here is still CLI compatibility |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Depends on #2731
Closes #2733
Orphaned assets can still be accessed via the
/assets/{asset_id}/endpoint. This PR filters out orphaned assets from that endpoint, resulting in a404 Not Foundwhen attempting to access an orphaned asset.