Annotate hardcoded branding touchpoints with TODO: BRANDING markers#2767
Draft
yarikoptic wants to merge 1 commit into
Draft
Annotate hardcoded branding touchpoints with TODO: BRANDING markers#2767yarikoptic wants to merge 1 commit into
yarikoptic wants to merge 1 commit into
Conversation
Add TODO: BRANDING comments to every location where instance-specific branding (names, URLs, logos, colors, emails) is hardcoded, split into two groups: - BRANDING(name): 20 spots fixable with existing vendorization variables (settings.DANDI_INSTANCE_NAME / instanceStore.instanceName) - BRANDING / BRANDING START/END: 23 spots requiring new branding config (custom images, URLs, colors, funding text, etc.) Add doc/design/branding.md with full inventory, annotation conventions, EMBER archive assessment (from git diff origin/master...gh-aplbrain/prod), and future implementation notes. Add minimal Branding Annotations section to DEVELOPMENT.md pointing to the design doc. Co-Authored-By: Claude Code 2.1.90 / Claude Opus 4.6 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
TODO: BRANDINGmarkers (29 files, comments only, zero behavior change)BRANDING(name)(20 spots): pure "DANDI" → instance name substitutions, fixable with existingsettings.DANDI_INSTANCE_NAME/instanceStore.instanceNameBRANDING/BRANDING START/END(23 spots): require new branding config (logos, colors, URLs, funding text, support emails, etc.)doc/design/branding.mdwith full inventory, annotation conventions, and analysis of the EMBER archive fork (git diff origin/master...gh-aplbrain/prod)DEVELOPMENT.mdpointing to the design docDependencies
This is a documentation/annotation-only PR — no code behavior changes.
However, the next step (resolving
BRANDING(name)items) depends onbeing merged first, since that PR introduces the frontend
instanceStorethatBRANDING(name)fixes will use. Planned sequence:BRANDING(name)items using existing vendorization variablesBRANDINGitems (logos, URLs, colors, etc.)How to find annotations
Test plan
doc/design/branding.mdfor completeness against EMBER fork diff🤖 Generated with Claude Code