Skip to content

Annotate hardcoded branding touchpoints with TODO: BRANDING markers#2767

Draft
yarikoptic wants to merge 1 commit into
masterfrom
rf-branding
Draft

Annotate hardcoded branding touchpoints with TODO: BRANDING markers#2767
yarikoptic wants to merge 1 commit into
masterfrom
rf-branding

Conversation

@yarikoptic
Copy link
Copy Markdown
Member

@yarikoptic yarikoptic commented Apr 2, 2026

Summary

  • Annotate every hardcoded branding touchpoint in the codebase with TODO: BRANDING markers (29 files, comments only, zero behavior change)
  • Split annotations into two groups for phased resolution:
    • BRANDING(name) (20 spots): pure "DANDI" → instance name substitutions, fixable with existing settings.DANDI_INSTANCE_NAME / instanceStore.instanceName
    • BRANDING / BRANDING START/END (23 spots): require new branding config (logos, colors, URLs, funding text, support emails, etc.)
  • Add doc/design/branding.md with full inventory, annotation conventions, and analysis of the EMBER archive fork (git diff origin/master...gh-aplbrain/prod)
  • Add minimal "Branding Annotations" section to DEVELOPMENT.md pointing to the design doc

Dependencies

This is a documentation/annotation-only PR — no code behavior changes.

However, the next step (resolving BRANDING(name) items) depends on

being merged first, since that PR introduces the frontend instanceStore that BRANDING(name) fixes will use. Planned sequence:

  1. This PR: annotate all branding touchpoints and provides design doc/comparison against EMBER
  2. PR Replace hardcoded DANDI identifiers with dynamic instance config #2765: merge vendorization fixes (instanceName/instanceIdentifier dynamic in citations, HowToCite, etc.) for frontend
  3. Next PR: resolve all BRANDING(name) items using existing vendorization variables
  4. Future: design and implement new branding config for remaining BRANDING items (logos, URLs, colors, etc.)

How to find annotations

# All branding touchpoints
git grep "TODO: BRANDING"

# Only Group 1 (name substitution — easy wins)
git grep "BRANDING(name)"

# Only Group 2 (needs new config)
git grep "TODO: BRANDING" | grep -v "BRANDING(name)"

Test plan

  • Verify no behavior changes — this is comments-only, CI should remain green!
  • Review doc/design/branding.md for completeness against EMBER fork diff
  • attn: @dandi/ember please complement with what additional aspects to potentially bring in right away . Feel welcome to propose PR to annotate those places!

🤖 Generated with Claude Code

Add TODO: BRANDING comments to every location where instance-specific
branding (names, URLs, logos, colors, emails) is hardcoded, split into
two groups:

- BRANDING(name): 20 spots fixable with existing vendorization variables
  (settings.DANDI_INSTANCE_NAME / instanceStore.instanceName)
- BRANDING / BRANDING START/END: 23 spots requiring new branding config
  (custom images, URLs, colors, funding text, etc.)

Add doc/design/branding.md with full inventory, annotation conventions,
EMBER archive assessment (from git diff origin/master...gh-aplbrain/prod),
and future implementation notes.

Add minimal Branding Annotations section to DEVELOPMENT.md pointing to
the design doc.

Co-Authored-By: Claude Code 2.1.90 / Claude Opus 4.6 <noreply@anthropic.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant